Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h

Issue 1505713002: Include glyph overflow in SVG text bounding boxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compute and store glyph overflow per-fragment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h
diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h b/third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h
index f215fd60e4f0a2724f390078cf53ce4b0536e23c..778a94ba4719c4fa15be5b8596515e86ead8f244 100644
--- a/third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h
+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h
@@ -70,6 +70,13 @@ struct SVGTextFragment {
float width;
float height;
+ // Top and bottom are the amounts of glyph overflows exceeding the font metrics' ascent and descent, respectively.
+ float glyphOverflowTop;
fs 2015/12/14 09:59:31 I guess the time has come for me to respin and lan
+ float glyphOverflowBottom;
+ // Left and right are the amounts of glyph overflows exceeding the left and right edge of normal layout boundary, respectively.
+ float glyphOverflowLeft;
+ float glyphOverflowRight;
+
// Includes rotation/glyph-orientation-(horizontal|vertical) transforms, as well as orientation related shifts
// (see SVGTextLayoutEngine, which builds this transformation).
AffineTransform transform;

Powered by Google App Engine
This is Rietveld 408576698