third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h - Issue 1505713002: Include glyph overflow in SVG text bounding boxes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

Issue 1505713002: Include glyph overflow in SVG text bounding boxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More expectations Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

index 66d12909439a71e6581751170de0438ae07a0cd6..17e743a1e6e6511aa5a7e2817d7719ea6bcedb9f 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

@@ -49,6 +49,7 @@ public:

void setWidth(float width) { m_width = width; }

float height() const { return m_height; }

// TODO(kojii): We should store logical width (advance) and height instead

// of storing physical and calculate logical. crbug.com/544767

float advance(FontOrientation) const;