pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart - Issue 1505703003: extract StaticMemberContributor from PrefixedElementContributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

Issue 1505703003: extract StaticMemberContributor from PrefixedElementContributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart ('k') | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

index 23657fdedef0bd07638c2ad415ac5ea000b0781c..da6c15d6dbc7336e2d29168739aa953eb9fb3fb9 100644

--- a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

@@ -301,8 +301,9 @@ class _PrefixedIdentifierSuggestionBuilder

if (element != null) {

InterfaceType type = element.type;

if (type != null) {

- StaticClassElementSuggestionBuilder.suggestionsFor(

- request, type.element);

+ // Suggested by StaticMemberContributor

+ // StaticClassElementSuggestionBuilder.suggestionsFor(

+ // request, type.element);

}

return new Future.value(false);