Issue 15057005: Remove duplicated code in SkPictureRecord::drawRRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15057005: Remove duplicated code in SkPictureRecord::drawRRect (Closed)

Created:
7 years, 7 months ago by Justin Novosad

Modified:
7 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove duplicated code in SkPictureRecord::drawRRect Committed: https://code.google.com/p/skia/source/detail?r=9093

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -13 lines)			Patch
	M	src/core/SkPictureRecord.cpp	View		2 chunks	+3 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + a suggestion https://codereview.chromium.org/15057005/diff/1/src/core/SkPictureRecord.cpp File src/core/SkPictureRecord.cpp (right): https://codereview.chromium.org/15057005/diff/1/src/core/SkPictureRecord.cpp#newcode931 src/core/SkPictureRecord.cpp:931: void SkPictureRecord::drawRRect(const SkRRect& rrect, const ...

7 years, 7 months ago (2013-05-10 14:08:40 UTC) #2

Justin Novosad

7 years, 7 months ago (2013-05-10 14:39:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9093 (presubmit successful).

Expand Messages | Collapse Messages