Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1505683002: [turbofan] mark deopt-ing blocks as needing frame. (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

In addition to blocks making calls, blocks making the deopt call also need to be marked as such. BUG= Committed: https://crrev.com/da8fd00e4c820da661880274c5c544eb3c8d60b5 Cr-Commit-Position: refs/heads/master@{#32643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/frame-elider.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Mircea Trofin
5 years ago (2015-12-07 06:41:03 UTC) #3
Mircea Trofin
5 years ago (2015-12-07 06:41:04 UTC) #4
Jarin
lgtm
5 years ago (2015-12-07 07:21:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505683002/1
5 years ago (2015-12-07 07:22:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 07:26:14 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-07 07:27:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da8fd00e4c820da661880274c5c544eb3c8d60b5
Cr-Commit-Position: refs/heads/master@{#32643}

Powered by Google App Engine
This is Rietveld 408576698