Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 1505423002: win: Set shutdown order to make the handler shutdown as late as possible (Closed)

Created:
5 years ago by scottmg
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Set shutdown order to make the handler shutdown as late as possible At the default level, we might be terminated before the process we're watching, which would mean missing shutdown crashes. R=mark@chromium.org BUG=crashpad:84 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/e9a843c626b2edb4d6a3d201ef73406f2a5b7908

Patch Set 1 #

Total comments: 2

Patch Set 2 : plog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M handler/handler_main.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scottmg
5 years ago (2015-12-09 00:43:29 UTC) #2
Mark Mentovai
LGTM otherwise https://codereview.chromium.org/1505423002/diff/1/handler/handler_main.cc File handler/handler_main.cc (right): https://codereview.chromium.org/1505423002/diff/1/handler/handler_main.cc#newcode342 handler/handler_main.cc:342: LOG(ERROR) << "SetProcessShutdownParameters"; PLOG instead of LOG
5 years ago (2015-12-09 00:51:53 UTC) #3
scottmg
https://codereview.chromium.org/1505423002/diff/1/handler/handler_main.cc File handler/handler_main.cc (right): https://codereview.chromium.org/1505423002/diff/1/handler/handler_main.cc#newcode342 handler/handler_main.cc:342: LOG(ERROR) << "SetProcessShutdownParameters"; On 2015/12/09 00:51:52, Mark Mentovai wrote: ...
5 years ago (2015-12-09 00:54:50 UTC) #4
scottmg
5 years ago (2015-12-09 00:55:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e9a843c626b2edb4d6a3d201ef73406f2a5b7908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698