Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2163)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.cc

Issue 1505403003: Remove const declaration of POD locals in actions bar code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_bar.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/browser_actions_container.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.cc b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
index 29658f480f918bc32b92328042c8962cd1fdbbd7..3c03cbea69cc8657f1eb7447e25b285cdb31ffd4 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
@@ -713,20 +713,20 @@ void BrowserActionsContainer::OnPaint(gfx::Canvas* canvas) {
// Convert back to a pixel offset into the container. First find the X
// coordinate of the drop icon.
- const int drop_icon_x = GetLayoutConstant(TOOLBAR_STANDARD_SPACING) +
+ int drop_icon_x = GetLayoutConstant(TOOLBAR_STANDARD_SPACING) +
(drop_position_->icon_in_row * ToolbarActionsBar::IconWidth(true));
// Next, find the space before the drop icon.
- const int space_before_drop_icon = platform_settings().item_spacing;
+ int space_before_drop_icon = platform_settings().item_spacing;
// Now place the drop indicator halfway between this and the end of the
// previous icon. If there is an odd amount of available space between the
// two icons (or the icon and the address bar) after subtracting the drop
// indicator width, this calculation puts the extra pixel on the left side
// of the indicator, since when the indicator is between the address bar and
// the first icon, it looks better closer to the icon.
- const int drop_indicator_x = drop_icon_x -
+ int drop_indicator_x = drop_icon_x -
((space_before_drop_icon + kDropIndicatorWidth) / 2);
- const int row_height = ToolbarActionsBar::IconHeight();
- const int drop_indicator_y = row_height * drop_position_->row;
+ int row_height = ToolbarActionsBar::IconHeight();
+ int drop_indicator_y = row_height * drop_position_->row;
gfx::Rect indicator_bounds(drop_indicator_x,
drop_indicator_y,
kDropIndicatorWidth,
« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_bar.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698