Don't create unexpected OOPIFs in --isolate-extensions.

content/browser/frame_host/render_frame_host_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_manager.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 2301 matching lines @@
 
 RenderFrameHostImpl* RenderFrameHostManager::UpdateStateForNavigate(
     const GURL& dest_url,
     SiteInstance* source_instance,
     SiteInstance* dest_instance,
     ui::PageTransition transition,
     bool dest_is_restore,
     bool dest_is_view_source_mode,
     const GlobalRequestID& transferred_request_id,
     int bindings) {
-  // Don't swap for subframes unless we are in --site-per-process.  We can get
-  // here in tests for subframes (e.g., NavigateFrameToURL).
-  if (!frame_tree_node_->IsMainFrame() &&
-      !SiteIsolationPolicy::AreCrossProcessFramesPossible()) {
-    return render_frame_host_.get();
+  if (!frame_tree_node_->IsMainFrame()) {
+    // Don't swap for subframes unless we are in an OOPIF-enabled mode.  We can
+    // get here in tests for subframes (e.g., NavigateFrameToURL).
+    if (!SiteIsolationPolicy::AreCrossProcessFramesPossible())

[ncarter (slow), 2015/12/08 20:14:13]

I think it might be cleaner to structure this as follows:

if (!frame_tree_node_->IsMainFrame()) {
  if (!IsRendererTransferNeededForNavigation(render_frame_host_.get(),
                                             dest_url)) {
    return render_frame_host_.get();
  }
  // Continuing in this case will result in an out-of-process iframe.
  CHECK(SiteIsolationPolicy::AreCrossProcessFramesPossible());
}

[Charlie Reis, 2015/12/08 20:34:11]

Sure.  As you noted offline, we may not get to the code below in
--site-per-process if we're already in the right site, but that's basically a
no-op anyway.  (We'll also need to improve
IsRendererTransferNeededForNavigation, but we already knew that.)

+      return render_frame_host_.get();
+
+    // If we are in an OOPIF mode that only applies to some sites, only swap if
+    // the policy determines that a transfer would have been needed.  We can get
+    // here for session restore.
+    if (!SiteIsolationPolicy::UseDedicatedProcessesForAllSites() &&

[ncarter (slow), 2015/12/08 20:14:13]

I don't think you need to check UseDedicatedProcessesForAllSites here.
IsRendererTransferNeededForNavigation takes it into consideration.

[Charlie Reis, 2015/12/08 20:34:11]

Acknowledged.

+        !IsRendererTransferNeededForNavigation(render_frame_host_.get(),
+                                               dest_url)) {
+      DCHECK(!dest_instance ||
+             dest_instance == render_frame_host_->GetSiteInstance());
+      return render_frame_host_.get();
+    }
   }
 
   SiteInstance* current_instance = render_frame_host_->GetSiteInstance();
   scoped_refptr<SiteInstance> new_instance = GetSiteInstanceForNavigation(
       dest_url, source_instance, dest_instance, nullptr, transition,
       dest_is_restore, dest_is_view_source_mode);
 
   // If we are currently navigating cross-process to a pending RFH for a
   // different SiteInstance, we want to get back to normal and then navigate as
   // usual.  We will reuse the pending RFH below if it matches the destination
@@ skipping 323 matching lines @@
 int RenderFrameHostManager::GetOpenerRoutingID(SiteInstance* instance) {
   if (!frame_tree_node_->opener())
     return MSG_ROUTING_NONE;
 
   return frame_tree_node_->opener()
       ->render_manager()
       ->GetRoutingIdForSiteInstance(instance);
 }
 
 }  // namespace content