SkBitmap::installPixels(const SkPixmap&);

SkBitmap::installPixels(const SkPixmap&);

Committed: https://skia.googlesource.com/skia/+/e36ec871768eb4f5372540c1167ff7ec592f2bec

[hal.canary, 2015-12-08 18:32:18]

halcanary@google.com changed reviewers:
+ reed@google.com

[hal.canary, 2015-12-08 18:32:19]

PTAL

[hal.canary, 2015-12-08 18:32:22]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 18:32:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505333002/1

[reed1, 2015-12-08 18:41:19]

lgtm

nit: lets not inline it, as I think it can be come common, and make the
call-sites pay extra setup.

[reed1, 2015-12-08 18:41:23]

The CQ bit was unchecked by reed@google.com

[hal.canary, 2015-12-08 18:53:25]

On 2015/12/08 at 18:41:19, reed wrote:
> lgtm
> 
> nit: lets not inline it, as I think it can be come common, and make the
call-sites pay extra setup.

done.

[hal.canary, 2015-12-08 18:53:47]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-12-08 18:53:47]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1505333002/#ps20001
(title: "not inline")

[commit-bot: I haz the power, 2015-12-08 18:53:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505333002/20001

[commit-bot: I haz the power, 2015-12-09 03:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 03:02:32]

Failed to apply patch for src/images/SkImageEncoder.cpp:
While running git apply --index -3 -p1;
  error: patch failed: src/images/SkImageEncoder.cpp:66
  Falling back to three-way merge...
  Applied patch to 'src/images/SkImageEncoder.cpp' with conflicts.
  U src/images/SkImageEncoder.cpp

Patch:       src/images/SkImageEncoder.cpp
Index: src/images/SkImageEncoder.cpp
diff --git a/src/images/SkImageEncoder.cpp b/src/images/SkImageEncoder.cpp
index
cea567816bad7d74c95147490d17307bd4b99e99..22bbc57c2f593a083734311f0c2dadb5f4994947
100644
--- a/src/images/SkImageEncoder.cpp
+++ b/src/images/SkImageEncoder.cpp
@@ -66,10 +66,7 @@ SkData* SkImageEncoder::EncodeData(const SkImageInfo& info,
const void* pixels,
 SkData* SkImageEncoder::EncodeData(const SkPixmap& pixmap,
                                    Type t, int quality) {
     SkBitmap bm;
-    if (!bm.installPixels(pixmap.info(),
-                          const_cast<void*>(pixmap.addr()),
-                          pixmap.rowBytes(),
-                          pixmap.ctable(), nullptr, nullptr)) {
+    if (!bm.installPixels(pixmap)) {
         return nullptr;
     }
     bm.setImmutable();

[commit-bot: I haz the power, 2015-12-09 03:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[hal.canary, 2015-12-09 18:58:20]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-12-09 18:58:21]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1505333002/#ps40001
(title: "2015-12-09 (Wednesday) 13:58:05 EST")

[commit-bot: I haz the power, 2015-12-09 18:58:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505333002/40001

[hal.canary, 2015-12-09 19:26:38]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2015-12-09 19:26:58]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-12-09 19:27:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505333002/40001

[commit-bot: I haz the power, 2015-12-09 19:37:01]

Description was changed from

==========
SkBitmap::installPixels(const SkPixmap&);
==========

to

==========
SkBitmap::installPixels(const SkPixmap&);

Committed:
https://skia.googlesource.com/skia/+/e36ec871768eb4f5372540c1167ff7ec592f2bec
==========

[commit-bot: I haz the power, 2015-12-09 19:37:02]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e36ec871768eb4f5372540c1167ff7ec592f2bec