[perf-insights] Trace corpus cleanup endpoint

[perf-insights] Trace corpus cleanup endpoint

R=simonhatch@chromium.org

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/181d6df89dca8453f701582455a3784bd74fafeb

[oystein (OOO til 10th of July), 2015-12-09 00:48:08]

Patchset #1 (id:1) has been deleted

[oystein (OOO til 10th of July), 2015-12-09 00:48:15]

Patchset #1 (id:20001) has been deleted

[oystein (OOO til 10th of July), 2015-12-09 00:48:20]

Patchset #1 (id:40001) has been deleted

[oystein (OOO til 10th of July), 2015-12-09 00:48:27]

Patchset #1 (id:60001) has been deleted

[oystein (OOO til 10th of July), 2015-12-09 00:49:07]

ptal

[shatch, 2015-12-09 15:00:46]

https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
File perf_insights/perf_insights/endpoints/corpus_cleanup.py (right):

https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
perf_insights/perf_insights/endpoints/corpus_cleanup.py:6: import json
nit: don't think this and datastore_errors are used.

https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
perf_insights/perf_insights/endpoints/corpus_cleanup.py:11: from
perf_insights.trace_info import TraceInfo
nit: order

https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
perf_insights/perf_insights/endpoints/corpus_cleanup.py:18: default_retry_params
= gcs.RetryParams(initial_delay=0.2,
nit: Could probably just import the cloud_helper and not dup this code.

[oystein (OOO til 10th of July), 2015-12-09 19:20:35]

https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
File perf_insights/perf_insights/endpoints/corpus_cleanup.py (right):

https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
perf_insights/perf_insights/endpoints/corpus_cleanup.py:6: import json
On 2015/12/09 15:00:46, shatch wrote:
> nit: don't think this and datastore_errors are used.

Done.

https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
perf_insights/perf_insights/endpoints/corpus_cleanup.py:11: from
perf_insights.trace_info import TraceInfo
On 2015/12/09 15:00:46, shatch wrote:
> nit: order

Done.

https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
perf_insights/perf_insights/endpoints/corpus_cleanup.py:18: default_retry_params
= gcs.RetryParams(initial_delay=0.2,
On 2015/12/09 15:00:46, shatch wrote:
> nit: Could probably just import the cloud_helper and not dup this code.

Done.

[shatch, 2015-12-09 19:37:30]

On 2015/12/09 19:20:35, Oystein wrote:
>
https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
> File perf_insights/perf_insights/endpoints/corpus_cleanup.py (right):
> 
>
https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
> perf_insights/perf_insights/endpoints/corpus_cleanup.py:6: import json
> On 2015/12/09 15:00:46, shatch wrote:
> > nit: don't think this and datastore_errors are used.
> 
> Done.
> 
>
https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
> perf_insights/perf_insights/endpoints/corpus_cleanup.py:11: from
> perf_insights.trace_info import TraceInfo
> On 2015/12/09 15:00:46, shatch wrote:
> > nit: order
> 
> Done.
> 
>
https://codereview.chromium.org/1505303003/diff/80001/perf_insights/perf_insi...
> perf_insights/perf_insights/endpoints/corpus_cleanup.py:18:
default_retry_params
> = gcs.RetryParams(initial_delay=0.2,
> On 2015/12/09 15:00:46, shatch wrote:
> > nit: Could probably just import the cloud_helper and not dup this code.
> 
> Done.

oops forgot lgtm

[oystein (OOO til 10th of July), 2015-12-09 19:41:20]

Description was changed from

==========
[perf-insights] Trace corpus cleanup endpoint

R=simonhatch@chromium.org
==========

to

==========
[perf-insights] Trace corpus cleanup endpoint

R=simonhatch@chromium.org

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[oystein (OOO til 10th of July), 2015-12-09 19:41:22]

Committed patchset #3 (id:120001) manually as
181d6df89dca8453f701582455a3784bd74fafeb (presubmit successful).