Support for remote audio into tracks

webrtc/base/format_macros.h

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 55 matching lines @@
 #define PRIuNS "u"
 #endif
 #if !defined(PRIxNS)
 #define PRIxNS "x"
 #endif
 #endif
 #endif  // defined(WEBRTC_MAC)
 
 #else  // WEBRTC_WIN
 
+#include <inttypes.h>

[the sun, 2015/12/11 19:46:29]

hmmm, why?

[tommi, 2015/12/12 00:33:11]

If you look a couple of patch sets back, you'll see the windows trybots turn red
and fail with errors like this:

e:\b\depot_tools\win_toolchain\vs2013_files\vc\include\inttypes.h(126) : warning
C4005: 'PRId64' : macro redefinition
        e:\b\build\slave\win\build\src\webrtc\base\format_macros.h(77) : see
previous definition of 'PRId64'

The reason is that there was a bug here that audio_sinks.h triggered.
audio_sinks.h includes #include <inttypes.h>, but this file was being included
via transmit_mixer.cc _before_ audio_sink.h got included.
That caused the below definitions to be defined and they conflict with the ones
in <inittypes.h>

If you look a few lines up, you can see that we already do this for WEBRTC_POSIX
and we should be doing it for Windows as well.
See e.g. the file in Chromium:
https://code.google.com/p/chromium/codesearch#chromium/src/base/format_macros...

Maybe it's time to update this file.

+
 #if !defined(PRId64)
 #define PRId64 "I64d"
 #endif
 
 #if !defined(PRIu64)
 #define PRIu64 "I64u"
 #endif
 
 #if !defined(PRIx64)
 #define PRIx64 "I64x"
 #endif
 
 #if !defined(PRIuS)
 #define PRIuS "Iu"
 #endif
 
 #endif
 
 #endif  // WEBRTC_BASE_FORMAT_MACROS_H_