Revert of Create RenderSurface on Effect Tree

Revert of Create RenderSurface on Effect Tree (patchset #7 id:120001 of https://codereview.chromium.org/1491033002/ )

Reason for revert:
crbug.com/567529. Top crash.

Original issue's description:
> Create RenderSurface on Effect Tree
>
> Move RenderSurface creation reason to effect tree. Update LayerImpl's
> API to include SetForceRenderSurface. Update unittests.
>
> R=enne
> BUG=557160
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/4374c2cc231a7e5b6ae65d0e0814b5dccf445200
> Cr-Commit-Position: refs/heads/master@{#363544}

TBR=ajuma@chromium.org,enne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557160
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/effae046c6fc5de1a095966d89ebb495a4ad194e
Cr-Commit-Position: refs/heads/master@{#363815}

[weiliangc, 2015-12-08 21:53:46]

Created Revert of Create RenderSurface on Effect Tree

[commit-bot: I haz the power, 2015-12-08 21:57:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505243003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505243003/1

[commit-bot: I haz the power, 2015-12-08 22:06:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505243003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505243003/1

[commit-bot: I haz the power, 2015-12-08 22:11:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 22:11:27]

Failed to apply patch for cc/layers/layer_impl.cc:
While running git apply --index -3 -p1;
  error: patch failed: cc/layers/layer_impl.cc:85
  Falling back to three-way merge...
  Applied patch to 'cc/layers/layer_impl.cc' with conflicts.
  U cc/layers/layer_impl.cc

Patch:       cc/layers/layer_impl.cc
Index: cc/layers/layer_impl.cc
diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc
index
c6bb3807250abe5e742915adad8b4ff26974b311..f0e85b130018485a7cbcb43f6a1bea39104bb0ea
100644
--- a/cc/layers/layer_impl.cc
+++ b/cc/layers/layer_impl.cc
@@ -85,7 +85,6 @@
       num_dependents_need_push_properties_(0),
       sorting_context_id_(0),
       current_draw_mode_(DRAW_MODE_NONE),
-      force_render_surface_(false),
       num_layer_or_descendants_with_copy_request_(0),
       frame_timing_requests_dirty_(false),
       visited_(false),
@@ -278,6 +277,7 @@
   if (requests->empty())
     return;
 
+  DCHECK(render_surface());
   bool was_empty = copy_requests_.empty();
   for (auto& request : *requests)
     copy_requests_.push_back(std::move(request));
@@ -571,7 +571,6 @@
   layer->SetDrawsContent(DrawsContent());
   layer->SetHideLayerAndSubtree(hide_layer_and_subtree_);
   layer->SetHasRenderSurface(!!render_surface());
-  layer->SetForceRenderSurface(force_render_surface_);
   layer->SetFilters(filters());
   layer->SetBackgroundFilters(background_filters());
   layer->SetMasksToBounds(masks_to_bounds_);
@@ -1329,12 +1328,6 @@
       observer_type);
 }
 
-bool LayerImpl::AnimationsPreserveAxisAlignment() const {
-  return layer_animation_controller_
-             ? layer_animation_controller_->AnimationsPreserveAxisAlignment()
-             : layer_tree_impl_->AnimationsPreserveAxisAlignment(this);
-}
-
 bool LayerImpl::MaximumTargetScale(float* max_scale) const {
   if (!layer_animation_controller_)
     return layer_tree_impl_->MaximumTargetScale(this, max_scale);
@@ -1774,6 +1767,7 @@
     return;
 
   SetNeedsPushProperties();
+  layer_tree_impl()->set_needs_update_draw_properties();
   if (should_have_render_surface) {
     render_surface_ = make_scoped_ptr(new RenderSurfaceImpl(this));
     return;
@@ -1810,14 +1804,6 @@
   return draw_properties().screen_space_transform;
 }
 
-void LayerImpl::SetForceRenderSurface(bool force_render_surface) {
-  if (force_render_surface == force_render_surface_)
-    return;
-
-  force_render_surface_ = force_render_surface;
-  NoteLayerPropertyChanged();
-}
-
 Region LayerImpl::GetInvalidationRegion() {
   return Region(update_rect_);
 }

[commit-bot: I haz the power, 2015-12-08 22:16:27]

The CQ bit was unchecked by commit-bot@chromium.org

[weiliangc, 2015-12-08 22:57:33]

Description was changed from

==========
Revert of Create RenderSurface on Effect Tree (patchset #7 id:120001 of
https://codereview.chromium.org/1491033002/ )

Reason for revert:
crbug.com/567529. Top crash.

Original issue's description:
> Create RenderSurface on Effect Tree
> 
> Move RenderSurface creation reason to effect tree. Update LayerImpl's
> API to include SetForceRenderSurface. Update unittests.
> 
> R=enne
> BUG=557160
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/4374c2cc231a7e5b6ae65d0e0814b5dccf445200
> Cr-Commit-Position: refs/heads/master@{#363544}

TBR=ajuma@chromium.org,enne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557160
==========

to

==========
Revert of Create RenderSurface on Effect Tree (patchset #7 id:120001 of
https://codereview.chromium.org/1491033002/ )

Reason for revert:
crbug.com/567529. Top crash.

Original issue's description:
> Create RenderSurface on Effect Tree
> 
> Move RenderSurface creation reason to effect tree. Update LayerImpl's
> API to include SetForceRenderSurface. Update unittests.
> 
> R=enne
> BUG=557160
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/4374c2cc231a7e5b6ae65d0e0814b5dccf445200
> Cr-Commit-Position: refs/heads/master@{#363544}

TBR=ajuma@chromium.org,enne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557160
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[weiliangc, 2015-12-08 22:58:49]

The CQ bit was checked by weiliangc@chromium.org

[commit-bot: I haz the power, 2015-12-08 23:01:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505243003/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505243003/300001

[commit-bot: I haz the power, 2015-12-08 23:17:40]

Committed patchset #2 (id:300001)

[commit-bot: I haz the power, 2015-12-08 23:18:55]

Description was changed from

==========
Revert of Create RenderSurface on Effect Tree (patchset #7 id:120001 of
https://codereview.chromium.org/1491033002/ )

Reason for revert:
crbug.com/567529. Top crash.

Original issue's description:
> Create RenderSurface on Effect Tree
> 
> Move RenderSurface creation reason to effect tree. Update LayerImpl's
> API to include SetForceRenderSurface. Update unittests.
> 
> R=enne
> BUG=557160
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/4374c2cc231a7e5b6ae65d0e0814b5dccf445200
> Cr-Commit-Position: refs/heads/master@{#363544}

TBR=ajuma@chromium.org,enne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557160
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Revert of Create RenderSurface on Effect Tree (patchset #7 id:120001 of
https://codereview.chromium.org/1491033002/ )

Reason for revert:
crbug.com/567529. Top crash.

Original issue's description:
> Create RenderSurface on Effect Tree
>
> Move RenderSurface creation reason to effect tree. Update LayerImpl's
> API to include SetForceRenderSurface. Update unittests.
>
> R=enne
> BUG=557160
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/4374c2cc231a7e5b6ae65d0e0814b5dccf445200
> Cr-Commit-Position: refs/heads/master@{#363544}

TBR=ajuma@chromium.org,enne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557160
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/effae046c6fc5de1a095966d89ebb495a4ad194e
Cr-Commit-Position: refs/heads/master@{#363815}
==========

[commit-bot: I haz the power, 2015-12-08 23:18:56]

Patchset 2 (id:??) landed as
https://crrev.com/effae046c6fc5de1a095966d89ebb495a4ad194e
Cr-Commit-Position: refs/heads/master@{#363815}