Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1505233002: Use correct config variable in command buffer gl context (Closed)

Created:
5 years ago by Kimmo Kinnunen
Modified:
5 years ago
Reviewers:
hendrikw, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@commandbuffer-as-api-04-extended-config
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use correct config variable in command buffer gl context Use correct config variable in command buffer gl context. Before, the fConfig was errorneously used to initialize the local variable. eglChooseConfig would update the local variable and the fConfig member variable would never be updated. Also add error checks to all initialization function calls. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ef6a1ca531b58c725c42356c10d17cbf1930c40c

Patch Set 1 #

Patch Set 2 : remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -18 lines) Patch
M src/gpu/gl/command_buffer/SkCommandBufferGLContext.cpp View 4 chunks +43 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Kimmo Kinnunen
5 years ago (2015-12-08 12:46:21 UTC) #4
Kimmo Kinnunen
5 years ago (2015-12-08 12:46:21 UTC) #5
bsalomon
lgtm
5 years ago (2015-12-08 15:03:10 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1490113005 Patch 120001). Please resolve the dependency and ...
5 years ago (2015-12-09 07:13:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505233002/20001
5 years ago (2015-12-09 07:22:20 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-09 07:52:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ef6a1ca531b58c725c42356c10d17cbf1930c40c

Powered by Google App Engine
This is Rietveld 408576698