Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: ash/frame/default_header_painter.cc

Issue 1505223004: Do not use assets for Ash window control button backgrounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/frame/custom_frame_view_ash_unittest.cc ('k') | ash/resources/ash_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/frame/default_header_painter.cc
diff --git a/ash/frame/default_header_painter.cc b/ash/frame/default_header_painter.cc
index 62a8465748b729fdcc2a512936fdaf31200aa6c4..135671aeccb2aaf1abb7f8eaf50a11aae905f0c2 100644
--- a/ash/frame/default_header_painter.cc
+++ b/ash/frame/default_header_painter.cc
@@ -4,6 +4,7 @@
#include "ash/frame/default_header_painter.h"
+#include "ash/ash_layout_constants.h"
#include "ash/frame/caption_buttons/frame_caption_button_container_view.h"
#include "ash/frame/header_painter_util.h"
#include "base/debug/leak_annotations.h"
@@ -101,6 +102,8 @@ void DefaultHeaderPainter::Init(
frame_ = frame;
view_ = header_view;
caption_button_container_ = caption_button_container;
+ caption_button_container_->SetButtonSize(
+ GetAshLayoutSize(AshLayoutSize::NON_BROWSER_CAPTION_BUTTON));
UpdateAllButtonImages();
}
@@ -293,35 +296,27 @@ bool DefaultHeaderPainter::ShouldUseLightImages() {
void DefaultHeaderPainter::UpdateAllButtonImages() {
bool use_light_images = ShouldUseLightImages();
- caption_button_container_->SetButtonImages(
+ caption_button_container_->SetButtonImage(
CAPTION_BUTTON_ICON_MINIMIZE,
use_light_images ? IDR_AURA_WINDOW_CONTROL_ICON_MINIMIZE_WHITE
- : IDR_AURA_WINDOW_CONTROL_ICON_MINIMIZE,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_H,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_P);
+ : IDR_AURA_WINDOW_CONTROL_ICON_MINIMIZE);
UpdateSizeButtonImages(use_light_images);
- caption_button_container_->SetButtonImages(
- CAPTION_BUTTON_ICON_CLOSE,
- use_light_images ? IDR_AURA_WINDOW_CONTROL_ICON_CLOSE_WHITE
- : IDR_AURA_WINDOW_CONTROL_ICON_CLOSE,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_H,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_P);
+ caption_button_container_->SetButtonImage(
+ CAPTION_BUTTON_ICON_CLOSE, use_light_images
+ ? IDR_AURA_WINDOW_CONTROL_ICON_CLOSE_WHITE
+ : IDR_AURA_WINDOW_CONTROL_ICON_CLOSE);
- caption_button_container_->SetButtonImages(
+ caption_button_container_->SetButtonImage(
CAPTION_BUTTON_ICON_LEFT_SNAPPED,
use_light_images ? IDR_AURA_WINDOW_CONTROL_ICON_LEFT_SNAPPED_WHITE
- : IDR_AURA_WINDOW_CONTROL_ICON_LEFT_SNAPPED,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_H,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_P);
+ : IDR_AURA_WINDOW_CONTROL_ICON_LEFT_SNAPPED);
- caption_button_container_->SetButtonImages(
+ caption_button_container_->SetButtonImage(
CAPTION_BUTTON_ICON_RIGHT_SNAPPED,
use_light_images ? IDR_AURA_WINDOW_CONTROL_ICON_RIGHT_SNAPPED_WHITE
- : IDR_AURA_WINDOW_CONTROL_ICON_RIGHT_SNAPPED,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_H,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_P);
+ : IDR_AURA_WINDOW_CONTROL_ICON_RIGHT_SNAPPED);
}
void DefaultHeaderPainter::UpdateSizeButtonImages(bool use_light_images) {
@@ -333,11 +328,8 @@ void DefaultHeaderPainter::UpdateSizeButtonImages(bool use_light_images) {
icon_id = use_light_images ? IDR_AURA_WINDOW_CONTROL_ICON_MAXIMIZE_WHITE
: IDR_AURA_WINDOW_CONTROL_ICON_MAXIMIZE;
}
- caption_button_container_->SetButtonImages(
- CAPTION_BUTTON_ICON_MAXIMIZE_RESTORE,
- icon_id,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_H,
- IDR_AURA_WINDOW_CONTROL_BACKGROUND_P);
+ caption_button_container_->SetButtonImage(
+ CAPTION_BUTTON_ICON_MAXIMIZE_RESTORE, icon_id);
}
gfx::Rect DefaultHeaderPainter::GetLocalBounds() const {
« no previous file with comments | « ash/frame/custom_frame_view_ash_unittest.cc ('k') | ash/resources/ash_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698