ash/ash_layout_constants.h - Issue 1505223004: Do not use assets for Ash window control button backgrounds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/ash_layout_constants.h

Issue 1505223004: Do not use assets for Ash window control button backgrounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ash layout constants file added Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef ASH_ASH_LAYOUT_CONSTANTS_H_

	6 #define ASH_ASH_LAYOUT_CONSTANTS_H_

	7

	8 #include "ui/gfx/geometry/size.h"

	9

	10 enum AshLayoutSize {

	11 // Size of a header button in a maximized browser window.
	Peter Kasting 2015/12/18 18:59:15 At least on Windows, these are called "caption but At least on Windows, these are called "caption buttons". Unless Ash consistently refers to them as "header buttons", I'd use that terminology everywhere. tdanderson 2016/01/04 23:11:14 Done. Show quoted text On 2015/12/18 18:59:15, Peter Kasting wrote: > At least on Windows, these are called "caption buttons". Unless Ash > consistently refers to them as "header buttons", I'd use that terminology > everywhere. Done.
	12 BROWSER_MAXIMIZED_HEADER_BUTTON,

	13

	14 // Size of a header button in a restored browser window.

	15 BROWSER_RESTORED_HEADER_BUTTON,

	16

	17 // Size of a header button in a non-browser window.

	18 DEFAULT_HEADER_BUTTON,
	Peter Kasting 2015/12/18 18:59:15 Nit: I might name this "NON_BROWSER_" instead of " Nit: I might name this "NON_BROWSER_" instead of "DEFAULT_" since browser windows are much more common than non-browser windows, and it's kinda weird to have "default" for the minority case. tdanderson 2016/01/04 23:11:14 Done. Show quoted text On 2015/12/18 18:59:15, Peter Kasting wrote: > Nit: I might name this "NON_BROWSER_" instead of "DEFAULT_" since browser > windows are much more common than non-browser windows, and it's kinda weird to > have "default" for the minority case. Done.
	19 };

	20

	21 gfx::Size GetAshLayoutSize(AshLayoutSize size);

	22

	23 #endif // ASH_ASH_LAYOUT_CONSTANTS_H_

OLD	NEW

« ash/ash.gyp ('K') | « ash/ash.gyp ('k') | ash/ash_layout_constants.cc » ('j') | ash/frame/caption_buttons/frame_caption_button.h » ('J')