Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc

Issue 1505223004: Do not use assets for Ash window control button backgrounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WIP for pkasting and estade feedback Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/web_app_left_header_view_ash.h" 5 #include "chrome/browser/ui/views/frame/web_app_left_header_view_ash.h"
6 6
7 #include "ash/frame/caption_buttons/frame_caption_button.h" 7 #include "ash/frame/caption_buttons/frame_caption_button.h"
8 #include "ash/frame/caption_buttons/frame_caption_button_container_view.h" 8 #include "ash/frame/caption_buttons/frame_caption_button_container_view.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/ssl/chrome_security_state_model_client.h" 10 #include "chrome/browser/ssl/chrome_security_state_model_client.h"
11 #include "chrome/browser/ui/browser_commands.h" 11 #include "chrome/browser/ui/browser_commands.h"
12 #include "chrome/browser/ui/layout_constants.h"
12 #include "chrome/browser/ui/views/frame/browser_view.h" 13 #include "chrome/browser/ui/views/frame/browser_view.h"
13 #include "components/toolbar/toolbar_model.h" 14 #include "components/toolbar/toolbar_model.h"
14 #include "content/public/browser/navigation_entry.h" 15 #include "content/public/browser/navigation_entry.h"
15 #include "grit/ash_resources.h" 16 #include "grit/ash_resources.h"
16 #include "ui/views/layout/box_layout.h" 17 #include "ui/views/layout/box_layout.h"
17 18
18 // static 19 // static
19 const char WebAppLeftHeaderView::kViewClassName[] = "WebAppLeftHeaderView"; 20 const char WebAppLeftHeaderView::kViewClassName[] = "WebAppLeftHeaderView";
20 21
21 WebAppLeftHeaderView::WebAppLeftHeaderView(BrowserView* browser_view) 22 WebAppLeftHeaderView::WebAppLeftHeaderView(BrowserView* browser_view)
22 : browser_view_(browser_view) { 23 : browser_view_(browser_view) {
23 SetLayoutManager( 24 SetLayoutManager(
24 new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0)); 25 new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0));
25 26
26 back_button_ = 27 back_button_ =
27 new ash::FrameCaptionButton(this, ash::CAPTION_BUTTON_ICON_BACK); 28 new ash::FrameCaptionButton(this, ash::CAPTION_BUTTON_ICON_BACK);
28 back_button_->SetImages( 29 back_button_->SetImage(ash::CAPTION_BUTTON_ICON_BACK,
29 ash::CAPTION_BUTTON_ICON_BACK, ash::FrameCaptionButton::ANIMATE_NO, 30 ash::FrameCaptionButton::ANIMATE_NO,
30 IDR_AURA_WINDOW_CONTROL_ICON_BACK, IDR_AURA_WINDOW_CONTROL_BACKGROUND_H, 31 IDR_AURA_WINDOW_CONTROL_ICON_BACK);
31 IDR_AURA_WINDOW_CONTROL_BACKGROUND_P);
32 AddChildView(back_button_); 32 AddChildView(back_button_);
33 33
34 location_icon_ = 34 location_icon_ =
35 new ash::FrameCaptionButton(this, ash::CAPTION_BUTTON_ICON_LOCATION); 35 new ash::FrameCaptionButton(this, ash::CAPTION_BUTTON_ICON_LOCATION);
36 AddChildView(location_icon_); 36 AddChildView(location_icon_);
37 37
38 Update(); 38 Update();
39 } 39 }
40 40
41 WebAppLeftHeaderView::~WebAppLeftHeaderView() { 41 WebAppLeftHeaderView::~WebAppLeftHeaderView() {
42 } 42 }
43 43
44 void WebAppLeftHeaderView::Update() { 44 void WebAppLeftHeaderView::Update() {
45 int icon_resource = browser_view_->browser()->toolbar_model()->GetIcon(); 45 int icon_resource = browser_view_->browser()->toolbar_model()->GetIcon();
46 location_icon_->SetImages(ash::CAPTION_BUTTON_ICON_LOCATION, 46 location_icon_->SetImage(ash::CAPTION_BUTTON_ICON_LOCATION,
47 ash::FrameCaptionButton::ANIMATE_NO, icon_resource, 47 ash::FrameCaptionButton::ANIMATE_NO,
48 IDR_AURA_WINDOW_CONTROL_BACKGROUND_H, 48 icon_resource);
49 IDR_AURA_WINDOW_CONTROL_BACKGROUND_P);
50 49
51 back_button_->SetState( 50 back_button_->SetState(
52 chrome::IsCommandEnabled(browser_view_->browser(), IDC_BACK) 51 chrome::IsCommandEnabled(browser_view_->browser(), IDC_BACK)
53 ? views::Button::STATE_NORMAL 52 ? views::Button::STATE_NORMAL
54 : views::Button::STATE_DISABLED); 53 : views::Button::STATE_DISABLED);
55 } 54 }
56 55
57 void WebAppLeftHeaderView::SetPaintAsActive(bool active) { 56 void WebAppLeftHeaderView::SetPaintAsActive(bool active) {
58 // TODO(benwells): Check that the disabled and inactive states should be 57 // TODO(benwells): Check that the disabled and inactive states should be
59 // drawn in the same way. 58 // drawn in the same way.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 return; 91 return;
93 92
94 ChromeSecurityStateModelClient* security_model_client = 93 ChromeSecurityStateModelClient* security_model_client =
95 ChromeSecurityStateModelClient::FromWebContents(tab); 94 ChromeSecurityStateModelClient::FromWebContents(tab);
96 DCHECK(security_model_client); 95 DCHECK(security_model_client);
97 96
98 chrome::ShowWebsiteSettings(browser_view_->browser(), tab, 97 chrome::ShowWebsiteSettings(browser_view_->browser(), tab,
99 nav_entry->GetURL(), 98 nav_entry->GetURL(),
100 security_model_client->GetSecurityInfo()); 99 security_model_client->GetSecurityInfo());
101 } 100 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698