third_party/crashpad/DEPS - Issue 1505213004: Copy Crashpad into the Chrome tree instead of importing it via DEPS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/crashpad/DEPS

Issue 1505213004: Copy Crashpad into the Chrome tree instead of importing it via DEPS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # Crashpad has its own #include structure not rooted at Chromium’s root.
	Mark Mentovai 2015/12/08 23:36:24 Noting that this file needed a UTF-8 BOM for check Noting that this file needed a UTF-8 BOM for checkdeps to process it. scottmg 2015/12/08 23:47:18 I don't see one in https://codereview.chromium.org Show quoted text On 2015/12/08 23:36:24, Mark Mentovai wrote: > Noting that this file needed a UTF-8 BOM for checkdeps to process it. I don't see one in https://codereview.chromium.org/1505213004/patch/10001/5678957424803840 is it just missing in the UI? Mark Mentovai 2015/12/09 22:09:45 scottmg wrote: scottmg wrote: Show quoted text > On 2015/12/08 23:36:24, Mark Mentovai wrote: > > Noting that this file needed a UTF-8 BOM for checkdeps to process it. > > I don't see one in > https://codereview.chromium.org/1505213004/patch/10001/5678957424803840 is it > just missing in the UI? Yeah, the UI isn’t showing it at all, but if you download https://codereview.chromium.org/download/issue1505213004_10001_56789574248038..., you’ll see it. I wonder what other characters we don’t indicate. :/ I wanted to fix checkdeps to make it assume UTF-8, but it uses execfile() to read in DEPS files, and you can’t give that an assumed encoding.
	6

	7 skip_child_includes = [

	8 'crashpad',

	9 ]

OLD	NEW

« DEPS ('K') | « DEPS ('k') | third_party/crashpad/OWNERS » ('j') | third_party/crashpad/OWNERS » ('J')