Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1505193003: Standalone: Null out _packagesPort after close. (Closed)

Created:
5 years ago by rmacnak
Modified:
5 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Standalone: Null out _packagesPort after close. Fixes crash in precompilation attempting to serialize a receive port. BUG=http://dartbug.com/25075 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/4d9a399f53f3414f9551541bc3798bb54c677536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/bin/builtin.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
5 years ago (2015-12-08 18:14:06 UTC) #2
Ivan Posva
LGTM -ip
5 years ago (2015-12-08 18:39:59 UTC) #3
rmacnak
5 years ago (2015-12-08 18:53:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d9a399f53f3414f9551541bc3798bb54c677536 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698