Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1505113005: Rename SettingsOnStartupPage section to onStartup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-router' is a simple router for settings. Its responsibilities: 7 * 'settings-router' is a simple router for settings. Its responsibilities:
8 * - Update the URL when the routing state changes. 8 * - Update the URL when the routing state changes.
9 * - Initialize the routing state with the initial URL. 9 * - Initialize the routing state with the initial URL.
10 * - Process and validate all routing state changes. 10 * - Process and validate all routing state changes.
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 { 93 {
94 url: '/fonts', 94 url: '/fonts',
95 page: 'basic', 95 page: 'basic',
96 section: 'appearance', 96 section: 'appearance',
97 subpage: ['appearance-fonts'], 97 subpage: ['appearance-fonts'],
98 subpageTitles: ['customizeFonts'], 98 subpageTitles: ['customizeFonts'],
99 }, 99 },
100 { 100 {
101 url: '/startup', 101 url: '/startup',
102 page: 'basic', 102 page: 'basic',
103 section: 'on-startup', 103 section: 'onStartup',
104 subpage: ['startup-urls'], 104 subpage: ['startup-urls'],
105 subpageTitles: ['onStartupSetPages'], 105 subpageTitles: ['onStartupSetPages'],
106 }, 106 },
107 { 107 {
108 url: '/searchEngines', 108 url: '/searchEngines',
109 page: 'basic', 109 page: 'basic',
110 section: 'search', 110 section: 'search',
111 subpage: ['search-engines'], 111 subpage: ['search-engines'],
112 subpageTitles: ['searchEnginesPageTitle'], 112 subpageTitles: ['searchEnginesPageTitle'],
113 }, 113 },
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 history.replaceState(historicState, null); 241 history.replaceState(historicState, null);
242 } 242 }
243 243
244 return; 244 return;
245 } 245 }
246 } 246 }
247 247
248 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 248 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
249 }, 249 },
250 }); 250 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/basic_page/basic_page.html ('k') | chrome/test/data/webui/settings/main_page_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698