Add CompositingReasons to compositor layer types.

Add CompositingReasons to compositor layer types.

BUG=240946
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202580

[shawnsingh, 2013-05-15 00:58:17]

Working prototype.  Still need to add the #if guards mechanism for the actual
patch for landing.

[danakj, 2013-05-15 14:02:43]

https://codereview.chromium.org/15051011/diff/1/cc/layers/layer.cc
File cc/layers/layer.cc (right):

https://codereview.chromium.org/15051011/diff/1/cc/layers/layer.cc#newcode752
cc/layers/layer.cc:752: void
Layer::SetCompositingReasons(WebKit::WebCompositingReasons reasons) {
Add this to the layer unittests?

https://codereview.chromium.org/15051011/diff/1/cc/layers/layer.h
File cc/layers/layer.h (right):

https://codereview.chromium.org/15051011/diff/1/cc/layers/layer.h#newcode25
cc/layers/layer.h:25: #include
"third_party/WebKit/Source/Platform/chromium/public/WebCompositingReasons.h"
Can we avoid adding new WebKit headers in cc? AIUI We're trying to remove them
all.

[enne (OOO), 2013-05-15 15:51:51]

https://codereview.chromium.org/15051011/diff/1/cc/layers/layer.h
File cc/layers/layer.h (right):

https://codereview.chromium.org/15051011/diff/1/cc/layers/layer.h#newcode25
cc/layers/layer.h:25: #include
"third_party/WebKit/Source/Platform/chromium/public/WebCompositingReasons.h"
On 2013/05/15 14:02:43, danakj wrote:
> Can we avoid adding new WebKit headers in cc? AIUI We're trying to remove them
> all.

+1000

You'll need to add a parallel enum structure, some compile asserts, and
static_casts.  Here's an existing example:
https://code.google.com/p/chromium/codesearch#chromium/src/webkit/compositor_...

[shawnsingh, 2013-05-17 02:35:50]

Will do - thanks to both reviewers =)  I'll revisit this tomorrow (friday) if
possible.

[shawnsingh, 2013-05-21 20:32:46]

PTAL, this patch is actually intended for review/landing now.   Hopefully it's
the pattern you want.  I had to create yet-another-clone of the enum, and the
associated assertions for matching enums.

This patch is dependent on https://codereview.chromium.org/15181006/

[shawnsingh, 2013-05-24 02:08:03]

Dear reviewers, PTAL

The blink side has landed just now, I will run tryjobs here shortly.

[nduca, 2013-05-24 20:56:02]

LGTM

[nduca, 2013-05-24 21:24:37]

spoke verbally to dana, we think you're probably good to, especially given that
both dana and enne are out for a while :) go ahead and land!

[danakj, 2013-05-25 13:33:59]

LGTM w minor comments

https://codereview.chromium.org/15051011/diff/25001/cc/layers/compositing_rea...
File cc/layers/compositing_reasons.h (right):

https://codereview.chromium.org/15051011/diff/25001/cc/layers/compositing_rea...
cc/layers/compositing_reasons.h:47: typedef unsigned CompositingReasons;
nit: uint32 instead of unsigned

https://codereview.chromium.org/15051011/diff/25001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/15051011/diff/25001/cc/layers/layer_impl.cc#n...
cc/layers/layer_impl.cc:1007: CompositingReasonsAsValue(CompositingReasons
reasons) {
Is this method supposed to be static? Maybe it should be in the compositing
reasons header/cc file instead of here?

[shawnsingh, 2013-05-28 07:20:49]

Thanks for review -

https://codereview.chromium.org/15051011/diff/25001/cc/layers/compositing_rea...
File cc/layers/compositing_reasons.h (right):

https://codereview.chromium.org/15051011/diff/25001/cc/layers/compositing_rea...
cc/layers/compositing_reasons.h:47: typedef unsigned CompositingReasons;
On 2013/05/25 13:34:00, danakj wrote:
> nit: uint32 instead of unsigned

Done.

https://codereview.chromium.org/15051011/diff/25001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/15051011/diff/25001/cc/layers/layer_impl.cc#n...
cc/layers/layer_impl.cc:1007: CompositingReasonsAsValue(CompositingReasons
reasons) {
On 2013/05/25 13:34:00, danakj wrote:
> Is this method supposed to be static? Maybe it should be in the compositing
> reasons header/cc file instead of here?

For the sake of landing, I'm making it static but keeping it here.

Moving it to the reasons header/cc has some style issues that would require
another review; I'm happy to do it in a separate patch though.

[commit-bot: I haz the power, 2013-05-28 07:21:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/15051011/34001

[commit-bot: I haz the power, 2013-05-28 09:52:55]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-28 15:54:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/15051011/34001

[commit-bot: I haz the power, 2013-05-28 16:32:42]

Change committed as 202580