Issue 15051010: Move [Get|Set]UpdateURLData from ExtensionPrefs to ExtensionAPI (aka Module)

Issue 15051010: Move [Get|Set]UpdateURLData from ExtensionPrefs to ExtensionAPI (aka Module) (Closed)

Created:
7 years, 7 months ago by Devlin

Modified:
7 years, 7 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move [Get|Set]UpdateURLData from ExtensionPrefs to ExtensionAPI (aka Module) BUG=180083 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201474

Patch Set 2 : UpdateURLData accessor in module #

Total comments: 1

Patch Set 3 : Latest master + newline #

Patch Set 4 : Android Gypi #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -39 lines)			Patch
M	chrome/browser/extensions/api/module/module.h	View	1	3 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/api/module/module.cc	View	1 2	2 chunks	+28 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View	1 2 3	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View	1 2	2 chunks	+0 lines, -19 lines	0 comments	Download
M	chrome/browser/extensions/updater/extension_updater.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

https://chromiumcodereview.appspot.com/15051010/diff/1/chrome/browser/extensions/updater/extension_updater.cc File chrome/browser/extensions/updater/extension_updater.cc (right): https://chromiumcodereview.appspot.com/15051010/diff/1/chrome/browser/extensions/updater/extension_updater.cc#newcode549 chrome/browser/extensions/updater/extension_updater.cc:549: extension_prefs_->ReadPrefAsString(id, extension::kUpdateURLData, &data); I think it'd be better to ...

7 years, 7 months ago (2013-05-15 18:49:49 UTC) #2

Devlin

https://codereview.chromium.org/15051010/diff/1/chrome/browser/extensions/updater/extension_updater.cc File chrome/browser/extensions/updater/extension_updater.cc (right): https://codereview.chromium.org/15051010/diff/1/chrome/browser/extensions/updater/extension_updater.cc#newcode549 chrome/browser/extensions/updater/extension_updater.cc:549: extension_prefs_->ReadPrefAsString(id, extension::kUpdateURLData, &data); On 2013/05/15 18:49:49, Yoyo Zhou wrote: ...

7 years, 7 months ago (2013-05-15 23:12:29 UTC) #3

Yoyo Zhou

LGTM https://codereview.chromium.org/15051010/diff/8001/chrome/browser/extensions/api/module/module.cc File chrome/browser/extensions/api/module/module.cc (right): https://codereview.chromium.org/15051010/diff/8001/chrome/browser/extensions/api/module/module.cc#newcode19 chrome/browser/extensions/api/module/module.cc:19: namespace { newline after

7 years, 7 months ago (2013-05-16 18:39:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/15051010/22001

7 years, 7 months ago (2013-05-21 23:53:59 UTC) #5

Message was sent while issue was closed.

Change committed as 201474

Expand Messages | Collapse Messages