third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html - Issue 1505023004: ServiceWorker: Early reject error if url is something wrong.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

Issue 1505023004: ServiceWorker: Early reject error if url is something wrong. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

index b9aaeb4082fb927f4cc1b51372dc42aacf3de48d..5812561fda4a395f197270ad544c60f79a5d166d 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

@@ -40,9 +40,9 @@ t.step(function() {

' focused: true',

' frameType: top-level',

'openWindow() can open about:blank',

- 'openWindow() result: null',

+ 'openWindow() error is: TypeError',

'openWindow() can open about:crash',

- 'openWindow() result: null',

+ 'openWindow() error is: TypeError',

'openWindow() can not open an invalid url',

'openWindow() error is: TypeError',

'openWindow() can not open view-source scheme',