Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1505013003: simplify the way we disable sanitizers for yasm (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

simplify the way we disable sanitizers for yasm seems to work fine CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot BUG=skia: Committed: https://skia.googlesource.com/skia/+/77665b8a0721a15584eb62a7ac276149139f6ff8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gyp/yasm.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
5 years ago (2015-12-08 17:35:22 UTC) #2
msarett
LGTM
5 years ago (2015-12-08 17:36:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505013003/1
5 years ago (2015-12-08 17:37:07 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-08 18:04:47 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/77665b8a0721a15584eb62a7ac276149139f6ff8

Powered by Google App Engine
This is Rietveld 408576698