Revert of Release Oilpan heap singletons prior to LSan leak detection.

Revert of Release Oilpan heap singletons prior to LSan leak detection. (patchset #8 id:140001 of https://codereview.chromium.org/1491253004/ )

Reason for revert:
This caused compile errors on Oilpan + no-LSan bots.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/builds/31816

It doesn't seem to be trivial to fix the error, so let me revert.

Original issue's description:
> Release Oilpan heap singletons prior to LSan leak detection.
>
> Make Oilpan and LSan cooperate better. As Persistent<> references
> created via DEFINE_STATIC_LOCAL() and similar will be reachable to
> LSan's leak detection pass, the objects they refer to outside of
> the Oilpan heap will be reported as leaking.
>
> (This is in contrast to what happens in the non-Oilpan setting,
> where the (leaked) pointer created via DEFINE_STATIC_LOCAL() is
> stored in a local "static"; such non-global references are not
> considered roots to LSan and hence the objects reachable from
> those will not be reported as leaking.)
>
> Address the problem on the Oilpan side by having such "static"
> Persistent<>ly-held singletons be registered and tracked such
> that we're able to release them all just before shutting down
> and performing an extra round of GCs. Leaving a cleaner heap
> for LSan to work over. And to report no leaks over, ideally.
>
> As part of the changes needed to support this for Oilpan,
> wtf/LeakAnnotations.h offerings has been renamed and changed
> a bit:
>
>  * WTF_ANNOTATE_MEMORY_LEAK_SCOPE => LEAK_SANITIZER_DISABLED_SCOPE.
>    (but see LeakAnnotations.h for macro to use local to wtf/.)
>  * WTF_ANNOTATE_IGNORE_OBJECT_PTR => LEAK_SANITIZER_IGNORE_OBJECT.
>  * LEAK_SANITIZER_REGISTER_STATIC_LOCAL().
>
> R=haraken
> BUG=567257
>
> Committed: https://crrev.com/5699ffefdcb17f5150f0d9342d21f73b3e8958b7
> Cr-Commit-Position: refs/heads/master@{#363591}

TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567257
Committed: https://crrev.com/c604dae85fa7627e407ccd0dbe6017ea90704e0e
Cr-Commit-Position: refs/heads/master@{#363701}

[haraken, 2015-12-08 01:53:08]

Created Revert of Release Oilpan heap singletons prior to LSan leak detection.

[commit-bot: I haz the power, 2015-12-08 01:54:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505003003/1

[commit-bot: I haz the power, 2015-12-08 01:57:14]

Description was changed from

==========
Revert of Release Oilpan heap singletons prior to LSan leak detection. (patchset
#8 id:140001 of https://codereview.chromium.org/1491253004/ )

Reason for revert:
This caused compile errors on Oilpan + no-LSan bots.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/...

It doesn't seem to be trivial to fix the error, so let me revert.


Original issue's description:
> Release Oilpan heap singletons prior to LSan leak detection.
> 
> Make Oilpan and LSan cooperate better. As Persistent<> references
> created via DEFINE_STATIC_LOCAL() and similar will be reachable to
> LSan's leak detection pass, the objects they refer to outside of
> the Oilpan heap will be reported as leaking.
> 
> (This is in contrast to what happens in the non-Oilpan setting,
> where the (leaked) pointer created via DEFINE_STATIC_LOCAL() is
> stored in a local "static"; such non-global references are not
> considered roots to LSan and hence the objects reachable from
> those will not be reported as leaking.)
> 
> Address the problem on the Oilpan side by having such "static"
> Persistent<>ly-held singletons be registered and tracked such
> that we're able to release them all just before shutting down
> and performing an extra round of GCs. Leaving a cleaner heap
> for LSan to work over. And to report no leaks over, ideally.
> 
> As part of the changes needed to support this for Oilpan,
> wtf/LeakAnnotations.h offerings has been renamed and changed
> a bit:
> 
>  * WTF_ANNOTATE_MEMORY_LEAK_SCOPE => LEAK_SANITIZER_DISABLED_SCOPE.
>    (but see LeakAnnotations.h for macro to use local to wtf/.)
>  * WTF_ANNOTATE_IGNORE_OBJECT_PTR => LEAK_SANITIZER_IGNORE_OBJECT.
>  * LEAK_SANITIZER_REGISTER_STATIC_LOCAL().
> 
> R=haraken
> BUG=567257
> 
> Committed: https://crrev.com/5699ffefdcb17f5150f0d9342d21f73b3e8958b7
> Cr-Commit-Position: refs/heads/master@{#363591}

TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567257
==========

to

==========
Revert of Release Oilpan heap singletons prior to LSan leak detection. (patchset
#8 id:140001 of https://codereview.chromium.org/1491253004/ )

Reason for revert:
This caused compile errors on Oilpan + no-LSan bots.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/...

It doesn't seem to be trivial to fix the error, so let me revert.


Original issue's description:
> Release Oilpan heap singletons prior to LSan leak detection.
> 
> Make Oilpan and LSan cooperate better. As Persistent<> references
> created via DEFINE_STATIC_LOCAL() and similar will be reachable to
> LSan's leak detection pass, the objects they refer to outside of
> the Oilpan heap will be reported as leaking.
> 
> (This is in contrast to what happens in the non-Oilpan setting,
> where the (leaked) pointer created via DEFINE_STATIC_LOCAL() is
> stored in a local "static"; such non-global references are not
> considered roots to LSan and hence the objects reachable from
> those will not be reported as leaking.)
> 
> Address the problem on the Oilpan side by having such "static"
> Persistent<>ly-held singletons be registered and tracked such
> that we're able to release them all just before shutting down
> and performing an extra round of GCs. Leaving a cleaner heap
> for LSan to work over. And to report no leaks over, ideally.
> 
> As part of the changes needed to support this for Oilpan,
> wtf/LeakAnnotations.h offerings has been renamed and changed
> a bit:
> 
>  * WTF_ANNOTATE_MEMORY_LEAK_SCOPE => LEAK_SANITIZER_DISABLED_SCOPE.
>    (but see LeakAnnotations.h for macro to use local to wtf/.)
>  * WTF_ANNOTATE_IGNORE_OBJECT_PTR => LEAK_SANITIZER_IGNORE_OBJECT.
>  * LEAK_SANITIZER_REGISTER_STATIC_LOCAL().
> 
> R=haraken
> BUG=567257
> 
> Committed: https://crrev.com/5699ffefdcb17f5150f0d9342d21f73b3e8958b7
> Cr-Commit-Position: refs/heads/master@{#363591}

TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567257
==========

[commit-bot: I haz the power, 2015-12-08 01:57:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-08 01:58:19]

Description was changed from

==========
Revert of Release Oilpan heap singletons prior to LSan leak detection. (patchset
#8 id:140001 of https://codereview.chromium.org/1491253004/ )

Reason for revert:
This caused compile errors on Oilpan + no-LSan bots.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/...

It doesn't seem to be trivial to fix the error, so let me revert.


Original issue's description:
> Release Oilpan heap singletons prior to LSan leak detection.
> 
> Make Oilpan and LSan cooperate better. As Persistent<> references
> created via DEFINE_STATIC_LOCAL() and similar will be reachable to
> LSan's leak detection pass, the objects they refer to outside of
> the Oilpan heap will be reported as leaking.
> 
> (This is in contrast to what happens in the non-Oilpan setting,
> where the (leaked) pointer created via DEFINE_STATIC_LOCAL() is
> stored in a local "static"; such non-global references are not
> considered roots to LSan and hence the objects reachable from
> those will not be reported as leaking.)
> 
> Address the problem on the Oilpan side by having such "static"
> Persistent<>ly-held singletons be registered and tracked such
> that we're able to release them all just before shutting down
> and performing an extra round of GCs. Leaving a cleaner heap
> for LSan to work over. And to report no leaks over, ideally.
> 
> As part of the changes needed to support this for Oilpan,
> wtf/LeakAnnotations.h offerings has been renamed and changed
> a bit:
> 
>  * WTF_ANNOTATE_MEMORY_LEAK_SCOPE => LEAK_SANITIZER_DISABLED_SCOPE.
>    (but see LeakAnnotations.h for macro to use local to wtf/.)
>  * WTF_ANNOTATE_IGNORE_OBJECT_PTR => LEAK_SANITIZER_IGNORE_OBJECT.
>  * LEAK_SANITIZER_REGISTER_STATIC_LOCAL().
> 
> R=haraken
> BUG=567257
> 
> Committed: https://crrev.com/5699ffefdcb17f5150f0d9342d21f73b3e8958b7
> Cr-Commit-Position: refs/heads/master@{#363591}

TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567257
==========

to

==========
Revert of Release Oilpan heap singletons prior to LSan leak detection. (patchset
#8 id:140001 of https://codereview.chromium.org/1491253004/ )

Reason for revert:
This caused compile errors on Oilpan + no-LSan bots.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/...

It doesn't seem to be trivial to fix the error, so let me revert.

Original issue's description:
> Release Oilpan heap singletons prior to LSan leak detection.
>
> Make Oilpan and LSan cooperate better. As Persistent<> references
> created via DEFINE_STATIC_LOCAL() and similar will be reachable to
> LSan's leak detection pass, the objects they refer to outside of
> the Oilpan heap will be reported as leaking.
>
> (This is in contrast to what happens in the non-Oilpan setting,
> where the (leaked) pointer created via DEFINE_STATIC_LOCAL() is
> stored in a local "static"; such non-global references are not
> considered roots to LSan and hence the objects reachable from
> those will not be reported as leaking.)
>
> Address the problem on the Oilpan side by having such "static"
> Persistent<>ly-held singletons be registered and tracked such
> that we're able to release them all just before shutting down
> and performing an extra round of GCs. Leaving a cleaner heap
> for LSan to work over. And to report no leaks over, ideally.
>
> As part of the changes needed to support this for Oilpan,
> wtf/LeakAnnotations.h offerings has been renamed and changed
> a bit:
>
>  * WTF_ANNOTATE_MEMORY_LEAK_SCOPE => LEAK_SANITIZER_DISABLED_SCOPE.
>    (but see LeakAnnotations.h for macro to use local to wtf/.)
>  * WTF_ANNOTATE_IGNORE_OBJECT_PTR => LEAK_SANITIZER_IGNORE_OBJECT.
>  * LEAK_SANITIZER_REGISTER_STATIC_LOCAL().
>
> R=haraken
> BUG=567257
>
> Committed: https://crrev.com/5699ffefdcb17f5150f0d9342d21f73b3e8958b7
> Cr-Commit-Position: refs/heads/master@{#363591}

TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567257

Committed: https://crrev.com/c604dae85fa7627e407ccd0dbe6017ea90704e0e
Cr-Commit-Position: refs/heads/master@{#363701}
==========

[commit-bot: I haz the power, 2015-12-08 01:58:20]

Patchset 1 (id:??) landed as
https://crrev.com/c604dae85fa7627e407ccd0dbe6017ea90704e0e
Cr-Commit-Position: refs/heads/master@{#363701}

[sof, 2015-12-08 06:41:01]

lgtm, sorry - thanks for the revert.