Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1505003002: Revert of Reenables mash_wm_apptests (Closed)

Created:
5 years ago by sky
Modified:
5 years ago
Reviewers:
jam
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenables mash_wm_apptests (patchset #1 id:1 of https://codereview.chromium.org/1510563002/ ) Reason for revert: Flaky. Original issue's description: > Reenables mash_wm_apptests > > I believe the reason for the flake was build targets weren't correctly > setup. I fixed that as part of disabling ( > https://codereview.chromium.org/1497643002/ ). So, hopefully they just > work now. > > BUG=559412 > TEST=test only change > R=jam@chromium.org > TBR=jam@chromium.org > > Committed: https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 > Cr-Commit-Position: refs/heads/master@{#363552} TBR=jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=559412 Committed: https://crrev.com/87ba57a24d6a55f7332d3e07e1fa7300b7cc48b9 Cr-Commit-Position: refs/heads/master@{#363567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M mash/wm/window_manager_apptest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/tools/data/apptests View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sky
Created Revert of Reenables mash_wm_apptests
5 years ago (2015-12-07 20:25:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505003002/1
5 years ago (2015-12-07 20:26:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 20:31:28 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-07 20:32:23 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87ba57a24d6a55f7332d3e07e1fa7300b7cc48b9
Cr-Commit-Position: refs/heads/master@{#363567}

Powered by Google App Engine
This is Rietveld 408576698