Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1504993003: Revert of Adding CHECK(false) for case when input audio fails to start on Mac (Closed)

Created:
5 years ago by henrika (OOO until Aug 14)
Modified:
5 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding CHECK(false) for case when input audio fails to start on Mac (patchset #1 id:1 of https://codereview.chromium.org/1490103003/ ) Reason for revert: Have not been able to catch any crashes in 6 days and keeping this CHECK prevents us from making real changes. Will revert and possibly try this approach at a later stage if needed. Original issue's description: > Adding CHECK(false) for case when input audio fails to start on Mac > > BUG=549021 > > Committed: https://crrev.com/cbe08a1dda4438af98648a0a35f2797d5a265c19 > Cr-Commit-Position: refs/heads/master@{#362697} TBR=tommi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549021 Committed: https://crrev.com/92d50e3f821cc12854ebbb5bfe0701f8809004ff Cr-Commit-Position: refs/heads/master@{#363773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
henrika (OOO until Aug 14)
Created Revert of Adding CHECK(false) for case when input audio fails to start on Mac
5 years ago (2015-12-08 09:14:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504993003/1
5 years ago (2015-12-08 09:14:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 09:15:29 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-08 09:16:20 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92d50e3f821cc12854ebbb5bfe0701f8809004ff
Cr-Commit-Position: refs/heads/master@{#363773}

Powered by Google App Engine
This is Rietveld 408576698