Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

In the repro case the conic in question has a replicated control point at the end. These points end up being slightly different by the time they get to convert_noninflect_cubic_to_quads so the initial checks for a zero vector don't fire. The following checks, in the constrainWithinTangents path, do fire however leading to a premature termination of conversion to quads.

BUG=skia:4611
Committed: https://skia.googlesource.com/skia/+/f08ce6cd53c5607ed068f755036b062a8693a8dc

[robertphillips, 2015-12-07 22:12:56]

Description was changed from

==========
Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

BUG=skia:555779
==========

to

==========
Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

In the repro case the conic in question has a replicated control point at the
end. These points end up being slightly different by the time they get to
convert_noninflect_cubic_to_quads so the initial checks for a zero vector don't
fire. The following checks, in the constrainWithinTangents path, do fire however
leading to a premature termination of conversion to quads.

BUG=skia:555779
==========

[robertphillips, 2015-12-07 22:12:56]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2015-12-07 22:14:23]

Description was changed from

==========
Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

In the repro case the conic in question has a replicated control point at the
end. These points end up being slightly different by the time they get to
convert_noninflect_cubic_to_quads so the initial checks for a zero vector don't
fire. The following checks, in the constrainWithinTangents path, do fire however
leading to a premature termination of conversion to quads.

BUG=skia:555779
==========

to

==========
Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

In the repro case the conic in question has a replicated control point at the
end. These points end up being slightly different by the time they get to
convert_noninflect_cubic_to_quads so the initial checks for a zero vector don't
fire. The following checks, in the constrainWithinTangents path, do fire however
leading to a premature termination of conversion to quads.

BUG=555779
==========

[robertphillips, 2015-12-07 22:16:19]

Description was changed from

==========
Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

In the repro case the conic in question has a replicated control point at the
end. These points end up being slightly different by the time they get to
convert_noninflect_cubic_to_quads so the initial checks for a zero vector don't
fire. The following checks, in the constrainWithinTangents path, do fire however
leading to a premature termination of conversion to quads.

BUG=555779
==========

to

==========
Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

In the repro case the conic in question has a replicated control point at the
end. These points end up being slightly different by the time they get to
convert_noninflect_cubic_to_quads so the initial checks for a zero vector don't
fire. The following checks, in the constrainWithinTangents path, do fire however
leading to a premature termination of conversion to quads.

BUG=skia:4611
==========

[bsalomon, 2015-12-07 22:24:46]

lgtm

[robertphillips, 2015-12-07 22:32:17]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-07 22:32:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504983003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504983003/1

[commit-bot: I haz the power, 2015-12-07 22:48:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 22:48:13]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-12-08 13:18:31]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-12-08 13:18:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504983003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504983003/1

[commit-bot: I haz the power, 2015-12-08 13:19:14]

Description was changed from

==========
Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

In the repro case the conic in question has a replicated control point at the
end. These points end up being slightly different by the time they get to
convert_noninflect_cubic_to_quads so the initial checks for a zero vector don't
fire. The following checks, in the constrainWithinTangents path, do fire however
leading to a premature termination of conversion to quads.

BUG=skia:4611
==========

to

==========
Loosen check for zero vectors in GrPathUtils::convert_noninflect_cubic_to_quads

In the repro case the conic in question has a replicated control point at the
end. These points end up being slightly different by the time they get to
convert_noninflect_cubic_to_quads so the initial checks for a zero vector don't
fire. The following checks, in the constrainWithinTangents path, do fire however
leading to a premature termination of conversion to quads.

BUG=skia:4611

Committed:
https://skia.googlesource.com/skia/+/f08ce6cd53c5607ed068f755036b062a8693a8dc
==========

[commit-bot: I haz the power, 2015-12-08 13:19:14]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f08ce6cd53c5607ed068f755036b062a8693a8dc