Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: src/core/SkMatrix.cpp

Issue 1504933002: Fix up signed-integer-overflow warnings (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: reed@'s verbal review Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkBitmapProcState_matrixProcs.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkMatrix.cpp
diff --git a/src/core/SkMatrix.cpp b/src/core/SkMatrix.cpp
index b32f372bbdcece567e69ba2c57b8e2d08bf50ff6..6101eb9f9a57f66831abf0f95823ed68ed9799e8 100644
--- a/src/core/SkMatrix.cpp
+++ b/src/core/SkMatrix.cpp
@@ -156,7 +156,7 @@ uint8_t SkMatrix::computeTypeMask() const {
} else {
// Only test for scale explicitly if not affine, since affine sets the
// scale bit.
- if ((m00 - kScalar1Int) | (m11 - kScalar1Int)) {
+ if ((m00 ^ kScalar1Int) | (m11 ^ kScalar1Int)) {
mask |= kScale_Mask;
}
« no previous file with comments | « src/core/SkBitmapProcState_matrixProcs.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698