Index: nss/lib/pk11wrap/pk11slot.c |
diff --git a/nss/lib/pk11wrap/pk11slot.c b/nss/lib/pk11wrap/pk11slot.c |
index 1f6597b5ebb441d2fbc407eaaf8d52099cb0e6bd..d52c0204d9f006d1bf0be201e075b22e9a30fd70 100644 |
--- a/nss/lib/pk11wrap/pk11slot.c |
+++ b/nss/lib/pk11wrap/pk11slot.c |
@@ -400,6 +400,7 @@ PK11_NewSlotInfo(SECMODModule *mod) |
slot->minPassword = 0; |
slot->maxPassword = 0; |
slot->hasRootCerts = PR_FALSE; |
+ slot->hasRootTrust = PR_FALSE; |
slot->nssToken = NULL; |
return slot; |
} |
@@ -555,10 +556,10 @@ PK11_FindSlotsByNames(const char *dllName, const char* slotName, |
break; |
} |
if ((PR_FALSE == presentOnly || PK11_IsPresent(tmpSlot)) && |
- ( (!tokenName) || (tmpSlot->token_name && |
- (0==PORT_Strcmp(tmpSlot->token_name, tokenName)))) && |
- ( (!slotName) || (tmpSlot->slot_name && |
- (0==PORT_Strcmp(tmpSlot->slot_name, slotName)))) ) { |
+ ( (!tokenName) || |
+ (0==PORT_Strcmp(tmpSlot->token_name, tokenName)) ) && |
+ ( (!slotName) || |
+ (0==PORT_Strcmp(tmpSlot->slot_name, slotName)) ) ) { |
if (tmpSlot) { |
PK11_AddSlotToList(slotList, tmpSlot, PR_TRUE); |
slotcount++; |
@@ -1105,7 +1106,6 @@ PK11_InitToken(PK11SlotInfo *slot, PRBool loadCerts) |
{ |
CK_TOKEN_INFO tokenInfo; |
CK_RV crv; |
- char *tmp; |
SECStatus rv; |
PRStatus status; |
@@ -1139,8 +1139,8 @@ PK11_InitToken(PK11SlotInfo *slot, PRBool loadCerts) |
if (slot->isActiveCard) { |
slot->protectedAuthPath = PR_FALSE; |
} |
- tmp = PK11_MakeString(NULL,slot->token_name, |
- (char *)tokenInfo.label, sizeof(tokenInfo.label)); |
+ (void)PK11_MakeString(NULL,slot->token_name, |
+ (char *)tokenInfo.label, sizeof(tokenInfo.label)); |
slot->minPassword = tokenInfo.ulMinPinLen; |
slot->maxPassword = tokenInfo.ulMaxPinLen; |
PORT_Memcpy(slot->serial,tokenInfo.serialNumber,sizeof(slot->serial)); |
@@ -1349,7 +1349,6 @@ void |
PK11_InitSlot(SECMODModule *mod, CK_SLOT_ID slotID, PK11SlotInfo *slot) |
{ |
SECStatus rv; |
- char *tmp; |
CK_SLOT_INFO slotInfo; |
slot->functionList = mod->functionList; |
@@ -1371,7 +1370,7 @@ PK11_InitSlot(SECMODModule *mod, CK_SLOT_ID slotID, PK11SlotInfo *slot) |
* works because modules keep implicit references |
* from their slots, and won't unload and disappear |
* until all their slots have been freed */ |
- tmp = PK11_MakeString(NULL,slot->slot_name, |
+ (void)PK11_MakeString(NULL,slot->slot_name, |
(char *)slotInfo.slotDescription, sizeof(slotInfo.slotDescription)); |
slot->isHW = (PRBool)((slotInfo.flags & CKF_HW_SLOT) == CKF_HW_SLOT); |
#define ACTIVE_CARD "ActivCard SA" |
@@ -2052,7 +2051,7 @@ PK11_GetBestSlotMultipleWithAttributes(CK_MECHANISM_TYPE *type, |
PK11SlotInfo *slot = NULL; |
PRBool freeit = PR_FALSE; |
PRBool listNeedLogin = PR_FALSE; |
- int i; |
+ unsigned int i; |
SECStatus rv; |
list = PK11_GetSlotList(type[0]); |