Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 1504923010: Before finalizing scroll dimensions, check again whether we need scrollbars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tentative better fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
index 90ee7c61e648e136aaf97962698a7cf0c2a52ed5..74b1bb3c65416f3e13203ab79f13fe03fb08624c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
@@ -864,7 +864,9 @@ void LayoutBlock::finishDelayUpdateScrollInfo()
if (block.key->hasOverflowClip()) {
PaintLayerScrollableArea* scrollableArea = block.key->layer()->scrollableArea();
ScrollInfo& scrollInfo = block.value;
- scrollableArea->finalizeScrollDimensions(scrollInfo.scrollOffset, scrollInfo.autoHorizontalScrollBarChanged, scrollInfo.autoVerticalScrollBarChanged);
+ bool autoHorizontalScrollBarChanged, autoVerticalScrollBarChanged;
szager1 2015/12/15 21:43:30 I don't think you want new bool's here. Instead:
+ scrollableArea->updateScrollDimensions(scrollInfo.scrollOffset, autoHorizontalScrollBarChanged, autoVerticalScrollBarChanged);
+ scrollableArea->finalizeScrollDimensions(scrollInfo.scrollOffset, autoHorizontalScrollBarChanged || scrollInfo.autoHorizontalScrollBarChanged, autoVerticalScrollBarChanged || scrollInfo.autoVerticalScrollBarChanged);
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698