Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1504923009: [Chromecast] Fix media unit tests (Closed)

Created:
5 years ago by kmackay
Modified:
5 years ago
Reviewers:
halliwell, mbjorge
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fix media unit tests The AudioVideoPipelineDeviceTest was not stopping the monitor loop correctly. BUG= internal b/26133365 Committed: https://crrev.com/667512ff414d2864a10a549ffba666342ce231c0 Cr-Commit-Position: refs/heads/master@{#364467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc View 5 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kmackay
5 years ago (2015-12-10 20:14:45 UTC) #2
halliwell
On 2015/12/10 20:14:45, kmackay wrote: lgtm
5 years ago (2015-12-10 20:29:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504923009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504923009/1
5 years ago (2015-12-10 20:30:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 20:49:01 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 20:49:57 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/667512ff414d2864a10a549ffba666342ce231c0
Cr-Commit-Position: refs/heads/master@{#364467}

Powered by Google App Engine
This is Rietveld 408576698