Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1504913002: Revert of Enforce marking "override" for functions overriding Blink. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enforce marking "override" for functions overriding Blink. (patchset #19 id:360001 of https://codereview.chromium.org/1370923002/ ) Reason for revert: Missed one. Original issue's description: > Enforce marking "override" for functions overriding Blink. > > BUG=535367 > TEST=it all stays working > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > TBR=ben@chromium.org > > Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd > Cr-Commit-Position: refs/heads/master@{#363482} TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=535367 Committed: https://crrev.com/50e3df675d58385e566645effb6ccfd3c8562443 Cr-Commit-Position: refs/heads/master@{#363492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -131 lines) Patch
M android_webview/renderer/aw_content_settings_client.h View 1 chunk +4 lines, -4 lines 0 comments Download
M build/common.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/blink/web_scroll_offset_animation_curve_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/test_runner/mock_web_theme_engine.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/android/in_process/context_provider_in_process.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/blink_platform_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webthemeengine_impl_android.h View 1 chunk +7 lines, -6 lines 0 comments Download
M content/child/webthemeengine_impl_default.h View 1 chunk +7 lines, -6 lines 0 comments Download
M content/ppapi_plugin/ppapi_blink_platform_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/renderer/media/android/media_info_loader.h View 2 chunks +27 lines, -20 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 3 chunks +62 lines, -60 lines 0 comments Download
M content/renderer/media/android/webmediasession_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/vr/vr_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/wake_lock/wake_lock_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webscrollbarbehavior_impl_gtkoraura.h View 1 chunk +7 lines, -6 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Avi (use Gerrit)
Created Revert of Enforce marking "override" for functions overriding Blink.
5 years ago (2015-12-07 16:09:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504913002/1
5 years ago (2015-12-07 16:10:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 16:12:05 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-07 16:13:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50e3df675d58385e566645effb6ccfd3c8562443
Cr-Commit-Position: refs/heads/master@{#363492}

Powered by Google App Engine
This is Rietveld 408576698