Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1504833002: Split ParserBase into separate file (Closed)

Created:
5 years ago by rossberg
Modified:
5 years ago
Reviewers:
nikolaos, nickie
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Split ParserBase into separate file Reviving/redoing littledan's previous CL. R=nikolaos@chromium.org BUG= Committed: https://crrev.com/b6a2ff8ede46493e1c73a644463b1b764c28b300 Cr-Commit-Position: refs/heads/master@{#32658}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4473 lines) Patch
M src/parsing/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/parsing/parser-base.h View 3 chunks +3 lines, -1134 lines 0 comments Download
M src/parsing/preparser.h View 3 chunks +1 line, -3338 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
rossberg
5 years ago (2015-12-07 13:26:23 UTC) #1
nikolaos
lgtm https://codereview.chromium.org/1504833002/diff/1/src/parsing/preparser.cc File src/parsing/preparser.cc (right): https://codereview.chromium.org/1504833002/diff/1/src/parsing/preparser.cc#newcode14 src/parsing/preparser.cc:14: #include "src/parsing/parser-base.h" As it now is, preparsing.h includes ...
5 years ago (2015-12-07 13:44:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504833002/1
5 years ago (2015-12-07 13:48:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 14:26:30 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 14:26:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6a2ff8ede46493e1c73a644463b1b764c28b300
Cr-Commit-Position: refs/heads/master@{#32658}

Powered by Google App Engine
This is Rietveld 408576698