Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1504773002: Reland "[heap] Unify evacuating an object for new and old generation." (Closed)

Created:
5 years ago by Michael Lippautz
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Unify evacuating an object for new and old generation." R=hpayer@chromium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/fe3d409d763de9c3ca0b4ff5dabb3c2cd64d938c Cr-Commit-Position: refs/heads/master@{#32712}

Patch Set 1 : Baseline #

Patch Set 2 : Cleanup names of methods iterating live objects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -100 lines) Patch
M src/heap/mark-compact.h View 1 5 chunks +10 lines, -11 lines 0 comments Download
M src/heap/mark-compact.cc View 1 7 chunks +84 lines, -88 lines 0 comments Download
M src/heap/store-buffer.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Michael Lippautz
PTAL: this is the 2nd part of the refactoring that was reverted. Changes to baseline: ...
5 years ago (2015-12-07 09:53:08 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504773002/20001
5 years ago (2015-12-07 11:07:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 11:33:13 UTC) #7
Hannes Payer (out of office)
lgtm
5 years ago (2015-12-08 16:28:27 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504773002/20001
5 years ago (2015-12-09 11:54:16 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 12:32:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504773002/20001
5 years ago (2015-12-09 12:33:54 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 13:15:50 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-09 13:16:20 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe3d409d763de9c3ca0b4ff5dabb3c2cd64d938c
Cr-Commit-Position: refs/heads/master@{#32712}

Powered by Google App Engine
This is Rietveld 408576698