Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1876)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp

Issue 1504763004: [DevTools] Fix frontend host race and assert. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: documentObjectCleared Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
index c11ebd9c45899089ce3d22e6021f448fe82ecaa7..761ea1c29f516e93fb4f454f1d0d8fbc9881d2cf 100644
--- a/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
@@ -44,17 +44,8 @@
namespace blink {
WebDevToolsFrontend* WebDevToolsFrontend::create(
- WebView* view,
- WebDevToolsFrontendClient* client,
- const WebString& applicationLocale)
-{
- return new WebDevToolsFrontendImpl(toWebLocalFrameImpl(view->mainFrame()), client);
-}
-
-WebDevToolsFrontend* WebDevToolsFrontend::create(
WebLocalFrame* frame,
- WebDevToolsFrontendClient* client,
- const WebString& applicationLocale)
+ WebDevToolsFrontendClient* client)
{
return new WebDevToolsFrontendImpl(toWebLocalFrameImpl(frame), client);
}
@@ -70,6 +61,8 @@ WebDevToolsFrontendImpl::WebDevToolsFrontendImpl(
WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl()
{
+ if (m_devtoolsHost)
+ m_devtoolsHost->disconnectClient();
}
void WebDevToolsFrontendImpl::didClearWindowObject(WebLocalFrameImpl* frame)
« no previous file with comments | « third_party/WebKit/Source/core/inspector/DevToolsHost.idl ('k') | third_party/WebKit/public/web/WebDevToolsFrontend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698