Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2743)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

Issue 1504763004: [DevTools] Fix frontend host race and assert. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: documentObjectCleared Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
index edded9f9fb9190950b406749a3b1babb77da58ec..bdff33782b0511d76a8517fc5fad6123a96d1b94 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
@@ -112,29 +112,6 @@ static bool populateContextMenuItems(v8::Isolate* isolate, const v8::Local<v8::A
return true;
}
-void V8DevToolsHost::showContextMenuMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- if (info.Length() < 2)
- return;
-
- v8::Local<v8::Object> eventWrapper = v8::Local<v8::Object>::Cast(info[0]);
- if (!V8MouseEvent::wrapperTypeInfo.equals(toWrapperTypeInfo(eventWrapper)))
- return;
-
- Event* event = V8Event::toImpl(eventWrapper);
- if (!info[1]->IsArray())
- return;
-
- v8::Local<v8::Array> array = v8::Local<v8::Array>::Cast(info[1]);
- ContextMenu menu;
- if (!populateContextMenuItems(info.GetIsolate(), array, menu))
- return;
-
- DevToolsHost* devtoolsHost = V8DevToolsHost::toImpl(info.Holder());
- Vector<ContextMenuItem> items = menu.items();
- devtoolsHost->showContextMenu(event, items);
-}
-
void V8DevToolsHost::showContextMenuAtPointMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
if (info.Length() < 3)
« no previous file with comments | « content/renderer/devtools/devtools_client.cc ('k') | third_party/WebKit/Source/core/inspector/DevToolsHost.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698