[DevTools] Fix frontend host race and assert.

third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp

Index: third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
index c11ebd9c45899089ce3d22e6021f448fe82ecaa7..761ea1c29f516e93fb4f454f1d0d8fbc9881d2cf 100644
--- a/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
@@ -44,17 +44,8 @@
 namespace blink {
 
 WebDevToolsFrontend* WebDevToolsFrontend::create(
-    WebView* view,
-    WebDevToolsFrontendClient* client,
-    const WebString& applicationLocale)
-{
-    return new WebDevToolsFrontendImpl(toWebLocalFrameImpl(view->mainFrame()), client);
-}
-
-WebDevToolsFrontend* WebDevToolsFrontend::create(
     WebLocalFrame* frame,
-    WebDevToolsFrontendClient* client,
-    const WebString& applicationLocale)
+    WebDevToolsFrontendClient* client)
 {
     return new WebDevToolsFrontendImpl(toWebLocalFrameImpl(frame), client);
 }
@@ -70,6 +61,8 @@ WebDevToolsFrontendImpl::WebDevToolsFrontendImpl(
 
 WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl()
 {
+    if (m_devtoolsHost)

[pfeldman, 2015/12/07 21:38:42]

Do you have an idea on what is retaining it?

[dgozman, 2015/12/07 21:46:40]

I think bindings. Or oilpan destructing it later. It's refcounted, so we have to
account for that.

+        m_devtoolsHost->disconnectClient();
 }
 
 void WebDevToolsFrontendImpl::didClearWindowObject(WebLocalFrameImpl* frame)