Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1504763003: Make NamedMixinApplicationElementX and EnumClassElementX implement DeclarationSite. (Closed)

Created:
5 years ago by Johnni Winther
Modified:
4 years, 11 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make NamedMixinApplicationElementX and EnumClassElementX implement DeclarationSite. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/812527f5b3a4a0f0efcf51fa73e3c6df393febd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -21 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 5 chunks +42 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
5 years ago (2015-12-07 13:12:06 UTC) #2
Johnni Winther
ping
4 years, 11 months ago (2016-01-04 11:35:01 UTC) #3
ahe
lgtm
4 years, 11 months ago (2016-01-05 14:32:25 UTC) #4
Johnni Winther
4 years, 11 months ago (2016-01-06 10:55:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
812527f5b3a4a0f0efcf51fa73e3c6df393febd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698