Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Issue 1504753003: Use correct fill type and bounds for NVPR paths that are stroked with Skia (Closed)

Created:
5 years ago by Kimmo Kinnunen
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use correct fill type and bounds for NVPR paths that are stroked with Skia When using NVPR, sometimes paths must be stroked by Skia and then drawn with fill using NVPR. In these cases, use the fill type and bounds of the stroked path, not the original path. Fixes degeneratesegments for nvprmsaa backends. BUG=skia:4608 Committed: https://skia.googlesource.com/skia/+/c6e7a13489eda2abf7a03ea8de3a4abbab1c597d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -25 lines) Patch
M src/gpu/GrPath.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 4 chunks +3 lines, -22 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Kimmo Kinnunen
5 years ago (2015-12-07 09:04:35 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-07 14:20:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504753003/1
5 years ago (2015-12-08 06:05:01 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-08 07:39:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c6e7a13489eda2abf7a03ea8de3a4abbab1c597d

Powered by Google App Engine
This is Rietveld 408576698