Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1504733002: Implementation of WaitSet for new EDK. (Closed)

Created:
5 years ago by Anand Mistry (off Chromium)
Modified:
5 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-waitset-implementation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implementation of WaitSet for new EDK. BUG=556865 TEST=Modified MessagePumpMojo + page cycler against Mandoline. Committed: https://crrev.com/3975d224839deaa1860e0d9f6155702484cc1589 Cr-Commit-Position: refs/heads/master@{#364609}

Patch Set 1 #

Patch Set 2 : Rebase and port review comments from old EDK. #

Patch Set 3 : Rebase and port review comments from old EDK. #

Patch Set 4 : Add gyp rules. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -132 lines) Patch
M mojo/edk/system/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/edk/system/core.h View 1 chunk +14 lines, -0 lines 0 comments Download
M mojo/edk/system/core.cc View 1 2 3 chunks +75 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 1 2 3 chunks +31 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 1 2 3 chunks +61 lines, -0 lines 0 comments Download
A + mojo/edk/system/wait_set_dispatcher.h View 1 2 4 chunks +28 lines, -27 lines 0 comments Download
A + mojo/edk/system/wait_set_dispatcher.cc View 1 2 18 chunks +39 lines, -34 lines 0 comments Download
A + mojo/edk/system/wait_set_dispatcher_unittest.cc View 1 2 17 chunks +67 lines, -67 lines 0 comments Download
M mojo/mojo_edk.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/mojo_edk_tests.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/entrypoints.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
Anand Mistry (off Chromium)
This is a port of https://codereview.chromium.org/1461213002/ to the new EDK. Modifying MessagePumpMojo to use this ...
5 years ago (2015-12-07 06:01:19 UTC) #2
jam
Thanks for porting it. I defer to Yuzhu for review of the other change in ...
5 years ago (2015-12-09 16:33:55 UTC) #4
yzshen1
On 2015/12/09 16:33:55, jam wrote: > Thanks for porting it. > > I defer to ...
5 years ago (2015-12-10 22:03:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504733002/40001
5 years ago (2015-12-10 23:42:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/106433)
5 years ago (2015-12-11 00:08:50 UTC) #10
Anand Mistry (off Chromium)
On 2015/12/11 00:08:50, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-11 00:56:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504733002/60001
5 years ago (2015-12-11 02:07:57 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-11 03:45:26 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-11 03:46:02 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3975d224839deaa1860e0d9f6155702484cc1589
Cr-Commit-Position: refs/heads/master@{#364609}

Powered by Google App Engine
This is Rietveld 408576698