Initial import of v8-native WASM.

Initial import of v8-native WASM.

As discussed in person, this adds the code from v8-native-prototype into
V8 proper, guarded by GYP flags that do not build the code by default.
Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates
building of this code.

An additional header file is added to and exported from the compiler
directory, src/compiler/wasm-compiler.h. This exposes a limited interface
with opaque Node and Graph types to the decoder to build TF graphs, as
well as functions to compile WASM graphs.

The mjsunit tests added are blacklisted because they fail without the
WASM object exposed to JS, which is also disabled by the build config
option.

This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler.

R=mstarzinger@chromium.org, bradnelson@chromium.org
BUG=

Committed: https://crrev.com/4c5b3609fd4de3e0c1092373d1654862395ce40f
Cr-Commit-Position: refs/heads/master@{#32794}

[bradn, 2015-12-11 09:02:07]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2015-12-11 09:02:07]

Did you want to mention the hash of the commit from v8-native-proto you're
landing?

[titzer, 2015-12-11 09:12:09]

Description was changed from

==========
Initial import of v8-native WASM.

As discussed in person, this adds the code from v8-native-prototype into
V8 proper, guarded by GYP flags that do not build the code by default.
Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates
building of this code.

An additional header file is added to and exported from the compiler
directory, src/compiler/wasm-compiler.h. This exposes a limited interface
with opaque Node and Graph types to the decoder to build TF graphs, as
well as functions to compile WASM graphs.

The mjsunit tests added are blacklisted because they fail without the
WASM object exposed to JS, which is also disabled by the build config
option.

R=mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
==========

to

==========
Initial import of v8-native WASM.

As discussed in person, this adds the code from v8-native-prototype into
V8 proper, guarded by GYP flags that do not build the code by default.
Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates
building of this code.

An additional header file is added to and exported from the compiler
directory, src/compiler/wasm-compiler.h. This exposes a limited interface
with opaque Node and Graph types to the decoder to build TF graphs, as
well as functions to compile WASM graphs.

The mjsunit tests added are blacklisted because they fail without the
WASM object exposed to JS, which is also disabled by the build config
option.

This corresponds closely to
https://github.com/WebAssembly/v8-native-prototype/commit/1813a67db4e184c3bec...,
with some formatting fixes and moving some files into src/compiler.

R=mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
==========

[Michael Starzinger, 2015-12-11 09:15:14]

Looking good, only nits. Also I assume the BUILD.gn file will be adapted in a
later CL.

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:156: WasmGraphBuilder* builder;
nit: Fields don't follow the style guide, missing underscore.

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.h (right):

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.h:5: #ifndef V8_WASM_COMPILER_H_
nit: V8_COMPILER_WASM_COMPILER_H_

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.h:10: #include "src/wasm/wasm-opcodes.h"
nit: Since this header is allowed to be exported, we should add the following
comment (similar to pipeline.h) in front of the includes.

// Clients of this interface shouldn't depend on lots of compiler internals.
// Do not include anything from src/compiler here!

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.h:137: Zone* zone;
nit: Fields don't follow the style guide, missing underscore.

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.h:174: #endif  // V8_WASM_COMPILER_H_
nit: V8_COMPILER_WASM_COMPILER_H_

https://codereview.chromium.org/1504713014/diff/20001/test/unittests/unittest...
File test/unittests/unittests.gyp (right):

https://codereview.chromium.org/1504713014/diff/20001/test/unittests/unittest...
test/unittests/unittests.gyp:174: 'wasm/ast-decoder-unittest.cc',
nit: Stray empty newline. Also, please alpha-sort the list.

https://codereview.chromium.org/1504713014/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/1504713014/diff/20001/tools/gyp/v8.gyp#newcod...
tools/gyp/v8.gyp:1477: '../../src/wasm/module-decoder.cc',
nit: Stray tabs instead of whitespaces here.

https://codereview.chromium.org/1504713014/diff/20001/tools/gyp/v8.gyp#newcod...
tools/gyp/v8.gyp:1478: '../../src/wasm/module-decoder.h',
nit: And here.

[bradn, 2015-12-11 09:16:03]

lgtm

Sorry I merged aseem's change before I realized you had this read
But let's stay at whatever rev you grabbed this from (though please add to the
commit message).
I'll revert and we can reland.

[titzer, 2015-12-11 10:16:12]

On 2015/12/11 09:15:14, Michael Starzinger wrote:
> Looking good, only nits. Also I assume the BUILD.gn file will be adapted in a
> later CL.
> 

Right. The GN config will be added when we get rid of the v8_wasm GYP flag soon.

>
https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
> File src/compiler/wasm-compiler.cc (right):
> 
>
https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
> src/compiler/wasm-compiler.cc:156: WasmGraphBuilder* builder;
> nit: Fields don't follow the style guide, missing underscore.
> 
>
https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
> File src/compiler/wasm-compiler.h (right):
> 
>
https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
> src/compiler/wasm-compiler.h:5: #ifndef V8_WASM_COMPILER_H_
> nit: V8_COMPILER_WASM_COMPILER_H_
> 
>
https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
> src/compiler/wasm-compiler.h:10: #include "src/wasm/wasm-opcodes.h"
> nit: Since this header is allowed to be exported, we should add the following
> comment (similar to pipeline.h) in front of the includes.
> 
> // Clients of this interface shouldn't depend on lots of compiler internals.
> // Do not include anything from src/compiler here!
> 
>
https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
> src/compiler/wasm-compiler.h:137: Zone* zone;
> nit: Fields don't follow the style guide, missing underscore.
> 
>
https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
> src/compiler/wasm-compiler.h:174: #endif  // V8_WASM_COMPILER_H_
> nit: V8_COMPILER_WASM_COMPILER_H_
> 
>
https://codereview.chromium.org/1504713014/diff/20001/test/unittests/unittest...
> File test/unittests/unittests.gyp (right):
> 
>
https://codereview.chromium.org/1504713014/diff/20001/test/unittests/unittest...
> test/unittests/unittests.gyp:174: 'wasm/ast-decoder-unittest.cc',
> nit: Stray empty newline. Also, please alpha-sort the list.
> 
> https://codereview.chromium.org/1504713014/diff/20001/tools/gyp/v8.gyp
> File tools/gyp/v8.gyp (right):
> 
>
https://codereview.chromium.org/1504713014/diff/20001/tools/gyp/v8.gyp#newcod...
> tools/gyp/v8.gyp:1477: '../../src/wasm/module-decoder.cc',
> nit: Stray tabs instead of whitespaces here.
> 
>
https://codereview.chromium.org/1504713014/diff/20001/tools/gyp/v8.gyp#newcod...
> tools/gyp/v8.gyp:1478: '../../src/wasm/module-decoder.h',
> nit: And here.

[titzer, 2015-12-11 10:16:21]

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:156: WasmGraphBuilder* builder;
On 2015/12/11 09:15:14, Michael Starzinger wrote:
> nit: Fields don't follow the style guide, missing underscore.

Done.

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.h (right):

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.h:5: #ifndef V8_WASM_COMPILER_H_
On 2015/12/11 09:15:14, Michael Starzinger wrote:
> nit: V8_COMPILER_WASM_COMPILER_H_

Done.

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.h:10: #include "src/wasm/wasm-opcodes.h"
On 2015/12/11 09:15:14, Michael Starzinger wrote:
> nit: Since this header is allowed to be exported, we should add the following
> comment (similar to pipeline.h) in front of the includes.
> 
> // Clients of this interface shouldn't depend on lots of compiler internals.
> // Do not include anything from src/compiler here!

Done.

https://codereview.chromium.org/1504713014/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.h:137: Zone* zone;
On 2015/12/11 09:15:14, Michael Starzinger wrote:
> nit: Fields don't follow the style guide, missing underscore.

Done.

https://codereview.chromium.org/1504713014/diff/20001/test/unittests/unittest...
File test/unittests/unittests.gyp (right):

https://codereview.chromium.org/1504713014/diff/20001/test/unittests/unittest...
test/unittests/unittests.gyp:174: 'wasm/ast-decoder-unittest.cc',
On 2015/12/11 09:15:14, Michael Starzinger wrote:
> nit: Stray empty newline. Also, please alpha-sort the list.

Done.

https://codereview.chromium.org/1504713014/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/1504713014/diff/20001/tools/gyp/v8.gyp#newcod...
tools/gyp/v8.gyp:1477: '../../src/wasm/module-decoder.cc',
On 2015/12/11 09:15:14, Michael Starzinger wrote:
> nit: Stray tabs instead of whitespaces here.

Done.

https://codereview.chromium.org/1504713014/diff/20001/tools/gyp/v8.gyp#newcod...
tools/gyp/v8.gyp:1478: '../../src/wasm/module-decoder.h',
On 2015/12/11 09:15:14, Michael Starzinger wrote:
> nit: And here.

Done.

[titzer, 2015-12-11 10:17:24]

Description was changed from

==========
Initial import of v8-native WASM.

As discussed in person, this adds the code from v8-native-prototype into
V8 proper, guarded by GYP flags that do not build the code by default.
Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates
building of this code.

An additional header file is added to and exported from the compiler
directory, src/compiler/wasm-compiler.h. This exposes a limited interface
with opaque Node and Graph types to the decoder to build TF graphs, as
well as functions to compile WASM graphs.

The mjsunit tests added are blacklisted because they fail without the
WASM object exposed to JS, which is also disabled by the build config
option.

This corresponds closely to
https://github.com/WebAssembly/v8-native-prototype/commit/1813a67db4e184c3bec...,
with some formatting fixes and moving some files into src/compiler.

R=mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
==========

to

==========
Initial import of v8-native WASM.

As discussed in person, this adds the code from v8-native-prototype into
V8 proper, guarded by GYP flags that do not build the code by default.
Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates
building of this code.

An additional header file is added to and exported from the compiler
directory, src/compiler/wasm-compiler.h. This exposes a limited interface
with opaque Node and Graph types to the decoder to build TF graphs, as
well as functions to compile WASM graphs.

The mjsunit tests added are blacklisted because they fail without the
WASM object exposed to JS, which is also disabled by the build config
option.

This corresponds closely to
https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e57883...,
with some formatting fixes and moving some files into src/compiler.

R=mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
==========

[Michael Starzinger, 2015-12-11 10:21:41]

LGTM on the pieces outside the respective "wasm" directories.

[titzer, 2015-12-11 12:22:11]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-12-11 12:22:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/1504713014/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-12-11 12:22:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504713014/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504713014/80001

[commit-bot: I haz the power, 2015-12-11 12:26:20]

Description was changed from

==========
Initial import of v8-native WASM.

As discussed in person, this adds the code from v8-native-prototype into
V8 proper, guarded by GYP flags that do not build the code by default.
Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates
building of this code.

An additional header file is added to and exported from the compiler
directory, src/compiler/wasm-compiler.h. This exposes a limited interface
with opaque Node and Graph types to the decoder to build TF graphs, as
well as functions to compile WASM graphs.

The mjsunit tests added are blacklisted because they fail without the
WASM object exposed to JS, which is also disabled by the build config
option.

This corresponds closely to
https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e57883...,
with some formatting fixes and moving some files into src/compiler.

R=mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
==========

to

==========
Initial import of v8-native WASM.

As discussed in person, this adds the code from v8-native-prototype into
V8 proper, guarded by GYP flags that do not build the code by default.
Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates
building of this code.

An additional header file is added to and exported from the compiler
directory, src/compiler/wasm-compiler.h. This exposes a limited interface
with opaque Node and Graph types to the decoder to build TF graphs, as
well as functions to compile WASM graphs.

The mjsunit tests added are blacklisted because they fail without the
WASM object exposed to JS, which is also disabled by the build config
option.

This corresponds closely to
https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e57883...,
with some formatting fixes and moving some files into src/compiler.

R=mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2015-12-11 12:26:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-11 12:27:14]

Description was changed from

==========
Initial import of v8-native WASM.

As discussed in person, this adds the code from v8-native-prototype into
V8 proper, guarded by GYP flags that do not build the code by default.
Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates
building of this code.

An additional header file is added to and exported from the compiler
directory, src/compiler/wasm-compiler.h. This exposes a limited interface
with opaque Node and Graph types to the decoder to build TF graphs, as
well as functions to compile WASM graphs.

The mjsunit tests added are blacklisted because they fail without the
WASM object exposed to JS, which is also disabled by the build config
option.

This corresponds closely to
https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e57883...,
with some formatting fixes and moving some files into src/compiler.

R=mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
==========

to

==========
Initial import of v8-native WASM.

As discussed in person, this adds the code from v8-native-prototype into
V8 proper, guarded by GYP flags that do not build the code by default.
Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates
building of this code.

An additional header file is added to and exported from the compiler
directory, src/compiler/wasm-compiler.h. This exposes a limited interface
with opaque Node and Graph types to the decoder to build TF graphs, as
well as functions to compile WASM graphs.

The mjsunit tests added are blacklisted because they fail without the
WASM object exposed to JS, which is also disabled by the build config
option.

This corresponds closely to
https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e57883...,
with some formatting fixes and moving some files into src/compiler.

R=mstarzinger@chromium.org, bradnelson@chromium.org
BUG=

Committed: https://crrev.com/4c5b3609fd4de3e0c1092373d1654862395ce40f
Cr-Commit-Position: refs/heads/master@{#32794}
==========

[commit-bot: I haz the power, 2015-12-11 12:27:15]

Patchset 5 (id:??) landed as
https://crrev.com/4c5b3609fd4de3e0c1092373d1654862395ce40f
Cr-Commit-Position: refs/heads/master@{#32794}