Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1504673004: Strip meta-data when VM runs with --enable-mirrors=false (Closed)

Created:
5 years ago by hausner
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Strip meta-data when VM runs with --enable-mirrors=false When the mirrors system is unavailable, there is no need to create the fields for metadata annotations in code. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/23bfa8163de150f742af231aa986d206d887a83f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M runtime/vm/parser.cc View 13 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hausner
I there a specific test suite or flags that I should use to test this?
5 years ago (2015-12-07 18:35:44 UTC) #3
rmacnak
On 2015/12/07 18:35:44, hausner wrote: > I there a specific test suite or flags that ...
5 years ago (2015-12-07 18:41:25 UTC) #4
hausner
Tests pass with --noopt flag.
5 years ago (2015-12-07 20:20:28 UTC) #5
rmacnak
lgtm
5 years ago (2015-12-07 20:26:59 UTC) #6
hausner
5 years ago (2015-12-07 20:49:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23bfa8163de150f742af231aa986d206d887a83f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698