Issue 1504523002: Use a monotonic clock in the implementation of Stopwatch.

Issue 1504523002: Use a monotonic clock in the implementation of Stopwatch. (Closed)

Created:
5 years ago by rmacnak

Modified:
5 years ago

Reviewers:
Cutch, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use a monotonic clock in the implementation of Stopwatch. Rename OS::GetCurrentTraceMicros() to OS::GetCurrentMonotonicMicros(). BUG=http://dartbug.com/477 BUG=http://dartbug.com/12383 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/c99df050b106830ab22606caca8cae2142f55ef7

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -21 lines)			Patch
M	runtime/lib/stopwatch.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/timeline.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/os.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/os_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/os_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/os_macos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/os_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/profiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/timeline.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/timeline.cc	View	7 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 8 (3 generated)

rmacnak

On 2015/12/05 00:02:37, rmacnak wrote: Also related is https://dartbug.com/25055

5 years ago (2015-12-05 00:03:49 UTC) #3

rmacnak

On 2015/12/05 00:03:49, rmacnak wrote: > On 2015/12/05 00:02:37, rmacnak wrote: > > Also related ...

5 years ago (2015-12-05 00:04:11 UTC) #4

rmacnak

5 years ago (2015-12-08 18:12:11 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c99df050b106830ab22606caca8cae2142f55ef7 (presubmit successful).