Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1504513002: Fix an incorrect check in CPDF_DataAvail::CheckHintTables. (Closed)

Created:
5 years ago by Oliver Chang
Modified:
5 years ago
Reviewers:
Tom Sepez, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : simplify logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Oliver Chang
ptal. I'm not sure if there is still some other issue causing all these bad ...
5 years ago (2015-12-04 23:47:56 UTC) #1
Oliver Chang
(see patchset 2, patchset 1 was a derp).
5 years ago (2015-12-04 23:49:37 UTC) #2
Tom Sepez
lgtm
5 years ago (2015-12-05 00:13:15 UTC) #3
Oliver Chang
5 years ago (2015-12-05 00:17:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2d16308298f236ae81aa11a53f2d4e25b502dfac (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698