Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 15045002: Revert 198803 "Speed improvements to SubstringSetMatcher" (Closed)

Created:
7 years, 7 months ago by dewittj
Modified:
7 years, 7 months ago
Reviewers:
vabr (Chromium), battre
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 198803 "Speed improvements to SubstringSetMatcher" > Speed improvements to SubstringSetMatcher > > The main one is coputing the Aho-Corasick tree size in advance. > > Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations. > > This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%. > > BUG=236368 > > Review URL: https://chromiumcodereview.appspot.com/14780003 TBR=vabr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -121 lines) Patch
M trunk/src/extensions/common/matcher/substring_set_matcher.h View 4 chunks +11 lines, -15 lines 0 comments Download
M trunk/src/extensions/common/matcher/substring_set_matcher.cc View 10 chunks +44 lines, -106 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dewittj
7 years, 7 months ago (2013-05-07 21:51:53 UTC) #1
dewittj
Committed patchset #1 manually as r198805.
7 years, 7 months ago (2013-05-07 21:52:09 UTC) #2
battre
Failed with ../../extensions/common/matcher/substring_set_matcher.cc:254:error: undefined reference to 'extensions::SubstringSetMatcher::AhoCorasickNode::kNoSuchEdge' collect2: ld returned 1 exit status ninja: build ...
7 years, 7 months ago (2013-05-07 21:59:39 UTC) #3
vabr (Chromium)
7 years, 7 months ago (2013-05-08 10:08:06 UTC) #4
Message was sent while issue was closed.
LGTM, thanks for reverting.

I relanded this as https://codereview.chromium.org/15059003/.

Vaclav

On 2013/05/07 21:59:39, battre wrote:
> Failed with
> 
> ../../extensions/common/matcher/substring_set_matcher.cc:254:error: undefined
> reference to 'extensions::SubstringSetMatcher::AhoCorasickNode::kNoSuchEdge'
> collect2: ld returned 1 exit status
> ninja: build stopped: subcommand failed.

Powered by Google App Engine
This is Rietveld 408576698