Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1504493002: Added |-cancelJavaScriptDialogsForWebController:| to UI delegate. (Closed)

Created:
5 years ago by kkhorimoto
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added |-cancelJavaScriptDialogsForWebController:| to UI delegate. This is necessary to cancel enqueued JavaScript dialogs before their associated web view is deallocated. BUG=564916 Committed: https://crrev.com/a02d286ca7ce39be455730c93ea332628e20dcd3 Cr-Commit-Position: refs/heads/master@{#364268}

Patch Set 1 #

Total comments: 4

Patch Set 2 : SEL stack variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M ios/web/public/web_state/crw_web_user_interface_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kkhorimoto
5 years ago (2015-12-04 23:18:30 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/1504493002/diff/1/ios/web/web_state/ui/crw_web_controller.mm File ios/web/web_state/ui/crw_web_controller.mm (right): https://codereview.chromium.org/1504493002/diff/1/ios/web/web_state/ui/crw_web_controller.mm#newcode696 ios/web/web_state/ui/crw_web_controller.mm:696: cancelJavaScriptDialogsForWebController:)]) { Factoring SEL to a separate local ...
5 years ago (2015-12-04 23:24:11 UTC) #3
kkhorimoto
https://codereview.chromium.org/1504493002/diff/1/ios/web/web_state/ui/crw_web_controller.mm File ios/web/web_state/ui/crw_web_controller.mm (right): https://codereview.chromium.org/1504493002/diff/1/ios/web/web_state/ui/crw_web_controller.mm#newcode696 ios/web/web_state/ui/crw_web_controller.mm:696: cancelJavaScriptDialogsForWebController:)]) { On 2015/12/04 23:24:11, eugenebut wrote: > Factoring ...
5 years ago (2015-12-10 01:27:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504493002/20001
5 years ago (2015-12-10 01:28:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 02:53:59 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 02:54:57 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a02d286ca7ce39be455730c93ea332628e20dcd3
Cr-Commit-Position: refs/heads/master@{#364268}

Powered by Google App Engine
This is Rietveld 408576698