Allow explicitly passing generic function type args

Allow explicitly passing generic function type args

Also supports implicit dynamic correctly and ensures we have a sensible element, which fixes #25100

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/095310bb369fa0067e107ef710894cb434bdc31c

[Jennifer Messerly, 2015-12-04 23:26:48]

Description was changed from

==========
Allow explicitly passing generic function type args
Also supports implicit dynamic correctly and ensures we have a sensible element
==========

to

==========
Allow explicitly passing generic function type args

Also supports implicit dynamic correctly and ensures we have a sensible element,
which fixes #25100
==========

[Jennifer Messerly, 2015-12-04 23:26:48]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com

[Jennifer Messerly, 2015-12-04 23:27:30]

This implements the last big missing case with generic methods.

[Jennifer Messerly, 2015-12-04 23:29:10]

https://codereview.chromium.org/1504483002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/1504483002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1831: if
(genericFunction.boundTypeParameters.isEmpty) {
FYI, I'm not super happy that we need this "uninstantiate" logic. But it seems
like it has to happen until we can integrate the "upwards inference" with our
other inference.

[Leaf, 2015-12-05 00:50:41]

lgtm!  This is exciting to see, looks great!

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:1997: [FunctionType type])
Document what type is in the comment?

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:3933: [FunctionType type])
ditto?

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:4238: [DartType type])
also.

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:4325: (definingType.element as
dynamic).type.typeArguments;
Lack of a common superclass? Maybe at least a comment or assertion to document
the intended types that reach here?

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:4507: * [baseElement], defined by
the [definingType].
Comment cut & pasted?

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:8720: * [baseElement], defined by
the [definingType].
update comment.

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:9510: * [baseElement], defined by
the [definingType].
update comment.  I think here and elsewhere there is a pre-existing cut&paste
error - they all refer to "constructor".  :)

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:11262: * [baseElement], defined by
the [definingType].
comment.

[Jennifer Messerly, 2015-12-07 17:46:42]

Description was changed from

==========
Allow explicitly passing generic function type args

Also supports implicit dynamic correctly and ensures we have a sensible element,
which fixes #25100
==========

to

==========
Allow explicitly passing generic function type args

Also supports implicit dynamic correctly and ensures we have a sensible element,
which fixes #25100

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/095310bb369fa0067e107ef710894cb434bdc31c
==========

[Jennifer Messerly, 2015-12-07 17:46:43]

Committed patchset #4 (id:60001) manually as
095310bb369fa0067e107ef710894cb434bdc31c (presubmit successful).

[Jennifer Messerly, 2015-12-07 17:46:58]

Thanks!

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:1997: [FunctionType type])
On 2015/12/05 00:50:40, Leaf wrote:
> Document what type is in the comment?

Done.

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:3933: [FunctionType type])
On 2015/12/05 00:50:40, Leaf wrote:
> ditto?

Done.

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:4325: (definingType.element as
dynamic).type.typeArguments;
On 2015/12/05 00:50:40, Leaf wrote:
> Lack of a common superclass? Maybe at least a comment or assertion to document
> the intended types that reach here?

yup, exactly. I actually have an idea for how to fix this. Let me give it a
shot.

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:4507: * [baseElement], defined by
the [definingType].
On 2015/12/05 00:50:40, Leaf wrote:
> Comment cut & pasted?

Done.

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:4507: * [baseElement], defined by
the [definingType].
On 2015/12/05 00:50:40, Leaf wrote:
> Comment cut & pasted?

Done.

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:8720: * [baseElement], defined by
the [definingType].
On 2015/12/05 00:50:40, Leaf wrote:
> update comment.

Done.

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:9510: * [baseElement], defined by
the [definingType].
On 2015/12/05 00:50:40, Leaf wrote:
> update comment.  I think here and elsewhere there is a pre-existing cut&paste
> error - they all refer to "constructor".  :)

Done.

https://codereview.chromium.org/1504483002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/element.dart:11262: * [baseElement], defined by
the [definingType].
On 2015/12/05 00:50:40, Leaf wrote:
> comment.

Done.