chrome/common/extensions/api/extension_action/action_info.cc - Issue 1504453002: Allow arbitrary sizes for extension icons (and bookmark app icons)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/action_info.cc

Issue 1504453002: Allow arbitrary sizes for extension icons (and bookmark app icons) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test updated Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/action_info.cc

diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc

index a3be61b6447c46c5d3d0912dc408118b8f108de6..4059a9df59517af0f0d5699afcb342feb6983c11 100644

--- a/chrome/common/extensions/api/extension_action/action_info.cc

+++ b/chrome/common/extensions/api/extension_action/action_info.cc

@@ -91,7 +91,7 @@ scoped_ptr<ActionInfo> ActionInfo::Load(const Extension* extension,

const base::DictionaryValue* icons_value = NULL;

std::string default_icon;

if (dict->GetDictionary(keys::kPageActionDefaultIcon, &icons_value)) {

- if (!manifest_handler_helpers::LoadAllIconsFromDictionary(

+ if (!manifest_handler_helpers::LoadIconsFromDictionary(

icons_value, &result->default_icon, error)) {

return scoped_ptr<ActionInfo>();

}