Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: chrome/browser/apps/drive/drive_app_converter.cc

Issue 1504453002: Allow arbitrary sizes for extension icons (and bookmark app icons) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/drive/drive_app_converter.cc
diff --git a/chrome/browser/apps/drive/drive_app_converter.cc b/chrome/browser/apps/drive/drive_app_converter.cc
index bbe79829339f1b0f007c93e94728fe248ba7b9be..fe3b611b4f723232f6f8440aba3739398db07181 100644
--- a/chrome/browser/apps/drive/drive_app_converter.cc
+++ b/chrome/browser/apps/drive/drive_app_converter.cc
@@ -117,16 +117,11 @@ void DriveAppConverter::Start() {
web_app_.title = base::UTF8ToUTF16(drive_app_info_.app_name);
web_app_.app_url = drive_app_info_.create_url;
- const std::set<int> allowed_sizes(extension_misc::kExtensionIconSizes,
- extension_misc::kExtensionIconSizes +
- extension_misc::kNumExtensionIconSizes);
std::set<int> pending_sizes;
for (size_t i = 0; i < drive_app_info_.app_icons.size(); ++i) {
const int icon_size = drive_app_info_.app_icons[i].first;
- if (allowed_sizes.find(icon_size) == allowed_sizes.end() ||
- pending_sizes.find(icon_size) != pending_sizes.end()) {
+ if (pending_sizes.find(icon_size) != pending_sizes.end())
continue;
- }
pending_sizes.insert(icon_size);
const GURL& icon_url = drive_app_info_.app_icons[i].second;
« no previous file with comments | « no previous file | chrome/browser/extensions/bookmark_app_helper.cc » ('j') | chrome/browser/extensions/bookmark_app_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698