Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1504403005: Add missing compile-time errors for async/await. (Closed)

Created:
5 years ago by Johnni Winther
Modified:
5 years ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing compile-time errors for async/await. Closes #22324 Closes #23716 R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/8e467be6b0eb582bd249ed4e0b9994e000261de5

Patch Set 1 #

Patch Set 2 : Fix after rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -65 lines) Patch
M pkg/compiler/lib/src/diagnostics/dart2js_messages.dart View 1 3 chunks +43 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 5 chunks +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 13 chunks +40 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +15 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/async_await_syntax_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
5 years ago (2015-12-09 14:48:17 UTC) #2
sigurdm
LGTM
5 years ago (2015-12-09 14:51:01 UTC) #3
Johnni Winther
5 years ago (2015-12-10 10:24:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8e467be6b0eb582bd249ed4e0b9994e000261de5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698